docs: fix outdated Python version and typo in CONTRIBUTING - #497
Open
EoinTrial wants to merge 1 commit into
Open
docs: fix outdated Python version and typo in CONTRIBUTING#497EoinTrial wants to merge 1 commit into
EoinTrial wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CONTRIBUTING.md lists Python 3.8 as the minimum required version to build pedalboard from source. This is outdated. The README states pedalboard is tested with Python 3.10–3.14, and the v0.9.16 changelog confirms Python 3.8 support was dropped. New contributors following CONTRIBUTING.md could be misled about the correct minimum version. Separately, there's a typo ("ahere") in the Issues section.
Solution
Updated the minimum Python version in the Prerequisites section from 3.8 to 3.10, matching the README and changelog. Changed "ahere" to "adhere".
Result
CONTRIBUTING.md now correctly states the supported minimum Python version, and the typo is corrected.