Skip to content
This repository was archived by the owner on Jan 8, 2023. It is now read-only.
This repository was archived by the owner on Jan 8, 2023. It is now read-only.

Wrong parameter order in BaseModelSerializer #7

Description

@blackvvine

Hi,

In the BaseModelSerializer definition, the Keras model is passed before the model ID:

def save(self, model, model_id):

But in the ShadowModelBundle class the model ID is passed before the model object:

self.serializer.save(ShadowModelBundle.MODEL_ID_FMT % i, shadow_model)

I think the BMS abstract class definition should be corrected with the two arguments swapped in order.

Best

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions