Consolidate API key and base URL property resolution to avoid code duplication#5376
Open
nicolaskrier wants to merge 1 commit intospring-projects:mainfrom
Open
Consolidate API key and base URL property resolution to avoid code duplication#5376nicolaskrier wants to merge 1 commit intospring-projects:mainfrom
nicolaskrier wants to merge 1 commit intospring-projects:mainfrom
Conversation
nicolaskrier
force-pushed
the
mistral-ai-default-properties
branch
2 times, most recently
from
99635d4 to
ca351a5
Compare
nicolaskrier
force-pushed
the
mistral-ai-default-properties
branch
from
ca351a5 to
38f719c
Compare
nicolaskrier
force-pushed
the
mistral-ai-default-properties
branch
from
38f719c to
87c853a
Compare
nicolaskrier
force-pushed
the
mistral-ai-default-properties
branch
2 times, most recently
from
e4b8396 to
9ede39c
Compare
- Introduce getApiKeyOrDefaultFrom and getBaseUrlOrDefaultFrom in MistralAiParentProperties - Add comprehensive unit tests for these methods - Replace duplicated logic in Mistral AI auto-configurations by using these methods Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com>
nicolaskrier
force-pushed
the
mistral-ai-default-properties
branch
from
9ede39c to
b312d2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getApiKeyOrDefaultFromandgetBaseUrlOrDefaultFrominMistralAiParentProperties,