Repository navigation
Treat WITH TIES as a keyword phrase in Transact-SQL - #998
Closed
zzoraemon043 wants to merge 1 commit into
Closed
zzoraemon043 wants to merge 1 commit into
zzoraemon043 wants to merge 1 commit into
Conversation
Collaborator
|
I'm adopting a new policy for this repository: no AI-generated contributions. I don't care how good they are. This is to preserve my sanity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #984
In
SELECT TOP (n) WITH TIES ...theWITHwas tokenized as the start of a CTE, so the clause was split over three lines andTIESwas not upper-cased. AddingWITH TIESto the Transact-SQL keyword phrases makes the tokenizer match the two words together, so a realWITH x AS (...)CTE is unaffected.Tests cover
TOP (n) WITH TIES,TOP (n) PERCENT WITH TIESandTOP n WITH TIESwithout parentheses. The full test suite passes.