Skip to content

Conversation

@rakibdev
Copy link

@rakibdev rakibdev commented Dec 19, 2025

adds #5358

  • respects scroll_speed config inside dialog
  • doesn't prevent default ctrl+click behavior when clicking tool (opening file)

@rakibdev rakibdev mentioned this pull request Dec 19, 2025
1 task
@rekram1-node
Copy link
Collaborator

may wanna merge dev into ur branch, i fixed a test

@rakibdev
Copy link
Author

done

@rekram1-node
Copy link
Collaborator

There are some changes shipping soon that may cause conflicts (most likely won't) but once they ship in I will give this more through review.

I'm wondering, should they be dialogs? Or should they be inlined like an expanded state? That u could open and close ofc

@rekram1-node
Copy link
Collaborator

Also can u attach screenshots / videos for changes u make?

@rakibdev
Copy link
Author

recording.mp4

I'm wondering, should they be dialogs? Or should they be inlined like an expanded state

Dialog is straightforward, requires minimal changes, doesn't shift layout or push contents down and outputs are mostly wall of text. Expand/collapse accordion needs more thought from UX perspective when tool calls are grouped.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants