Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the app’s graceful-exit shutdown flow to stop running servers via the ToolHive bulk stop endpoint (batch API) instead of issuing per-server stop requests, and updates the existing Vitest coverage accordingly.
Changes:
- Switch
stopAllServersto callpostApiV1BetaWorkloadsStoponce with anameslist. - Remove per-server stop fan-out (
Promise.allSettled) and associated aggregated failure reporting. - Update
graceful-exittests to validate the new batch-stop request shape and error behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
main/src/graceful-exit.ts |
Replaces per-server stop calls with a single bulk stop request and reuses the same polling-to-final-state flow. |
main/src/tests/graceful-exit.test.ts |
Updates mocks/expectations to assert a single bulk stop call (body.names) and aligns failure expectations with the new behavior. |
peppescg
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per title a little refactor using the batch api endpoint instead of calling stop on each server when we do the graceful exit