Conversation
Allow runtime_config in create and update workload API requests. Wire runtime overrides through image retrieval and persist them in RunConfig. Update API docs and tests for stacklok#3676. Signed-off-by: Mantas Suminas <mantas.sumin@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97e8aa6d9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3772 +/- ##
==========================================
- Coverage 66.57% 66.55% -0.02%
==========================================
Files 432 432
Lines 42215 42246 +31
==========================================
+ Hits 28103 28117 +14
- Misses 11970 11990 +20
+ Partials 2142 2139 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Avoid invalid protocol Dockerfiles when runtime override omits builder_image by merging missing fields with base runtime config. Add tests for merged behavior and override precedence. Signed-off-by: slyt3 <mantas.sumin@gmail.com>
Trim builder_image and ignore empty runtime_config payloads to avoid forwarding meaningless overrides.
github-actions
bot
added
size/S
Add explicit returns after fatal nil guards so staticcheck can prove dereferences are safe.
github-actions
bot
added
size/S
Signed-off-by: slyt3 <mantas.sumin@gmail.com>
github-actions
bot
added
size/S
|
I fixed the failing verify check separately: docs/server/swagger.json had an EOF newline mismatch; this is docs formatting only, not part of the #3676 runtime_config logic. |
github-actions
bot
added
size/S
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e6e895eee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Append additional_packages to base runtime defaults and filter blank package entries in API requests to avoid malformed build config.
github-actions
bot
added
size/S
1 participant
I added
runtime_configto workload to create and update API requests for #3676; It now passes the runtime image override into the build/retriever flow and stores it inRunConfig, updated API docs and tests