feat(fleetshard): add Pyroscope continuous profiling support#2670
Open
feat(fleetshard): add Pyroscope continuous profiling support#2670
Conversation
Add opt-in Pyroscope integration to fleetshard-sync for push-based continuous profiling. Controlled via environment variables: - PYROSCOPE_ENABLED: enable/disable (default: false) - PYROSCOPE_SERVER_ADDRESS: Pyroscope server URL (required when enabled) - PYROSCOPE_AUTH_TOKEN: optional auth token - PYROSCOPE_APPLICATION_NAME: app name tag (default: fleetshard-sync) Profiles exported: CPU, alloc, inuse, goroutines, mutex, block. Cluster ID automatically tagged on all profiles.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kovayur
reviewed
Apr 20, 2026
| pprofServer.Start() | ||
| defer pprofServer.Stop() | ||
|
|
||
| if config.Pyroscope.Enabled { |
Contributor
There was a problem hiding this comment.
Shall we disable/remove the standard pprof server?
Contributor
|
It looks like changes to the Helm chart are missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PYROSCOPE_ENABLED,PYROSCOPE_SERVER_ADDRESS,PYROSCOPE_AUTH_TOKEN, andPYROSCOPE_APPLICATION_NAMEenv varscluster_idTest plan
go build ./fleetshard/...compiles cleanly🤖 Generated with Claude Code