Repository navigation
fix(vtl): narrow template numbers through int32 after the range check - #1643
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| return int(t), true | ||
| return int(int32(t)), true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL alert #95 (incorrect conversion between integer types,
internal/vtl/eval.go:700) is still open ondevelopmentand fails the CodeQL check on the v2.14.0 release PR (#1640).toIntalready rejects anything outside the int32 range (and NaN) before converting, so the value always fits. CodeQL doesn't treat that range check as a guard for a conversion to the platform-sizedint, so both branches now convert throughint32explicitly:int(int32(t)). Behaviour is unchanged: in-range values convert the same way, fractions still truncate toward zero, and out-of-range values are still refused.Tested with
go test -raceoninternal/vtlandserver/aws/apigateway.