Repository navigation
Spruce up the iOS demo - #984
Open
michaelkirk wants to merge 2 commits into
Open
michaelkirk wants to merge 2 commits into
michaelkirk wants to merge 2 commits into
Conversation
Replace the "Sim" toggle with a labelled Simulated / CoreLocation picker that explains where each gets its location. While idle, show MapLibre's puck only when it agrees with the demo's location: MapLibre reads CoreLocation itself, so in simulated mode it would mark a different place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picking a destination, loading routes and choosing a route previously changed only the button label. - Mark the chosen destination with a pin. - Draw the loaded routes, then only the chosen one. - Fit the camera to the current location and destination. - Close search on every selection. It only closed when the destination changed, so re-selecting the same place left it open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know we want the demo to be minimal, but it was a little TOO sparse in my opinion.
Two things - I could split them up if you'd like, but I thought it might be more efficient to review this way.
1. the location toggle confused me, so I've made it clearer.
before
after
The widget got bigger. I could bury it in a settings toggle or something if it's offensive.
2. Previously there was no feedback as you clicked through "Choose Destination" etc. steps until routing.
Before
ferrostar-demo-before.mov.mp4
After
ferrostar-demo.mov.mp4
Note: "choose route" still looks like a no-op, but if you can get multiple alternate routes it'd make sense.