Repository navigation
Bump SwiftUI DSL to 0.26.1 - #993
Merged
Merged
Conversation
DSL 0.26.1 starts the location manager that `MapView` swaps in while the map shows the user location. Before this release, the navigation map can stay at 0, 0 after navigation starts from another screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps MapLibre SwiftUI DSL to 0.26.1, which includes maplibre/swiftui-dsl#150.
On iOS, the navigation map can stay at null island when navigation starts from another screen or map.
When navigation starts,
MapViewswaps the location manager on a live map.MapLibre Native stops the old manager in
setLocationManager:, but it does not start the new one(source).
So the map never gets the route origin from the navigating location manager.
The camera stays at its default center until the next navigation update.
DSL 0.26.1 starts the new manager after the swap.
Ferrostar needs no code change.
Testing
xcodebuild -scheme FerrostarCore-Package build -destination 'generic/platform=iOS Simulator'passes against 0.26.1.They showed that the map gets the route origin after the swap.
I did not keep these tests, because they need a real
MLNMapViewin a window and are not stable.🤖 Generated with Claude Code