[codex] Validate workflow response token#2797
Open
caydyan wants to merge 1 commit into
Open
Conversation
Author
|
Current-head validation rerun on
I also attempted broader |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /workflows/responsewith theSWWF_RESKEYenvironment token before processing the response body.x-api-token,x-swwf-reskey, orAuthorization: Bearer ...so the endpoint can work with existing project header conventions while satisfying the token-header requirement.500when the server token is not configured and401when the request token is missing or invalid.Databasemock withGetBountyByUnlockCodeso the handlers package compiles.Fixes #1930
Validation
go test ./handlers -run '^TestHandleWorkflowResponseTokenValidation$' -count=1\n-go test ./routes -run 'TestWorkflowRoutes' -count=1\n-go test ./... -run TestNonExistent -count=0\n\n## Note\n-go test ./handlers -run 'TestHandleWorkflowResponse|TestHandleWorkflowResponseTokenValidation' -count=1requires the local test Postgres onlocalhost:5532; in this environment it failed with connection refused after the package compiled.