chore: don't confuse Status translations with a dummy string #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the string gets picked up randomly by the main status app `make update-translations`, remove it
micieslak
approved these changes
Oct 17, 2025
micieslak
approved these changes
Oct 17, 2025
Member
There was a problem hiding this comment.
Looks ok, but please keep this repo as sth independent, including names of pr/commits.
It could be like Remove translated strings to avoid potential problems in client code
On the other hand it's also bug in status desktop. It may happen that 3rd party repo has translated strings, especially in some sub-projects.
Member
Author
|
OK, will filter the collected sources in the respective i18n cmake file instead, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make update-translations, remove it