TOML Specification conformance for writing, reading [[AoT]] #1962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOML writing/reading more spec-conformant:
Basic (scalar) types are emitted before tables/structs.
Partial support added for
[[array-of-tables]]on read.Multi dimensional array of tables support
dotted keys support for AoT (not tested)
Write ordering. Emit key/value scalars first to avoid interleaving tables and scalars that can confuse TOML readers; tables/structs follow.
[[array-of-tables]](read). Introduces a minimal pass that recognizes and aggregates repeated table headers into arrays. Dotted keys inside these arrays are not yet expanded/tested correctly.N-dim arrays. In case of AoT is not yet supported currently i see two approaches.
But i see confusion might arise, if we have a vector called items inside of the struct itself.
I want a review or direction of how i could approach this better, currently i put functionality where it seemed best fit, but i dont exactly like it, repetition of code, and it seems logical to put AoT handling for reading in the
reflectable || glz_object_top to avoid introducing, completely separate constexpr loop in the vector reading, but you might have a different idea. Also read.hpp line 794-822 behaves completely differently from 892-943 and I completely dont understand why...Also coud you please point me to a place where I can see how to itroduce meta specifier so I can mark table as inline.