FIX: macos build#2300
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: macOS build
Fixes the unsigned macOS build, which was failing to launch on macOS 14.4+ / macOS 26 due to inconsistent Team IDs between the (pre-signed) Electron Framework and the unsigned main binary, causing dyld to reject the load.
Background
electron-builder v26 no longer re-signs bundled frameworks when no signing certificate is provided. The Electron Framework ships pre-signed with the Electron project's Apple Team ID, while the main executable has no Team ID — dyld's validation refuses to load the app as a result.
Changes
launcher/afterPackMac.js(new file)afterPackhook that runs only ondarwin..appbundle withcodesign --force --deep --sign -, so all binaries share a consistent (empty) Team ID and dyld validation passes.launcher/vue.config.jsisSignedflag derived fromCSC_IDENTITY_AUTO_DISCOVERY !== "false".afterPackMac.jshook only for unsigned builds.hardenedRuntimeis now conditional onisSigned— it requires consistent Team IDs across binaries and only makes sense when actually signing.entitlements/entitlementsInheritare likewise only set on signed builds.Result