Repository navigation
Bring the Windows and Linux app close to parity with the Mac - #430
Merged
Merged
Conversation
Ports what the Mac has and the Rust app lacked: selection actions; the dictation and autocomplete gaps (delivery guard, Compose context, live transcript, accept keys, macros, statistics, learning, an autocomplete server); spoken summaries; remembered speakers; Files; screen search by meaning; the overnight review; Personal Context; coding-agent sessions; note and daily exports; routines; library health; retention review; the Actions, People and Projects workspaces; agent handoff; the command palette; Settings Overview and search; agents changing settings, behind the Mac's approval; and hosting paired phones and tablets. Also fixes bugs that reached users. Saving settings dropped keys this port didn't model, so a library from a Mac lost them. Microphone pickers were always empty. Closing the window during a recording lost its end time and job. Mic transcript rows were deleted on word overlap alone. Debug logs held typed text. Think accepted plain HTTP to a server off this computer, where the Mac requires HTTPS. Picture vectors outlived their pixels, and deleted sources left generated journals and work memory behind. Coding-agent sessions need an explicit choice here, unlike on the Mac: installs already saved that key as true without asking, so an update must not start reading them silently. Remembered speakers only suggest names, because the Mac's thresholds aren't calibrated for this voice model on real calls. Not ported: Gmail in meeting briefs, and Mac-only speech runtimes. All Windows code is only type-checked, and Wayland, real phones and real calls were never run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
589 strings into the 23 other interface languages, machine-assisted like the rest of the desktop catalog and in need of native-speaker review. The two hints that show the "Remember" trigger keep it in English or Serbian, the only words the parser recognises. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moves features out of the Mac-only lists, and says what differs where it does. Also removes a paragraph in PRIVACY.md that an old merge had duplicated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and Windows Follows #424 and #426 on the Mac: every pass walks the chosen folders again, so a change the crawl would leave out no longer starts one. It leaves out tmp and temp folders too, while a folder chosen on its own is still read whole. Unlike FSEvents, the watchers here often don't say whether a path is a file or a folder, so the path answers where it still exists. When nothing can tell, the change counts, unless it's in a hidden folder. Also restores the test of clean_other_names, lost when that function moved to lokalbot-core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lokalbot | b07d573 | Commit Preview URL Branch Preview URL |
Nov 03 2026, 01:32 AM |
The folder picker saves a rule under the home folder as `~\Code\client`, but only `~/` was expanded, so on Windows that exclusion matched nothing and sessions from an excluded folder were still read. A home path with backslashes was also left unnormalized. Found by the first real Windows CI run, which failed on a test that fed Unix paths to `Path::join`; that test now uses each platform's separator. The Windows job now runs every crate, so one run shows every failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stopping a pipe server woke its accept with a connection it closed at once. A Windows pipe listener skips a client that has already left, so if the thread hadn't reached ConnectNamedPipe yet, accept kept waiting and join waited on it forever. That could freeze the app on quit, or when agent settings control is turned off. The wake-up connection now stays open until the thread has gone. IpcServer, which already shipped, had the same bug. Found by the first full Windows CI run, where the test hung until the job timed out. Also fixes two tests that run failed: one fed a Unix path to Path::join, and one compared days across midnight on the runner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both failed on and off in xcodebuild test on master and on pull requests. Turning Files off deletes the index on the reader's and worker's queues, and the test gave that 300 ms. It now waits up to 20 s for the folder to go. FSEvents can report notes.txt, written just before its stream began, and that starts a second pass during the wait that should show none. The test now outlasts the watcher's latency before it counts, and again after the writes that can't alter the index: with a 2 s latency, the old 1 s wait could end before those writes had been reported at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Windows and Linux checks photographed the app's older pages only, so Files, Devices and Personal Context had never been seen on a real desktop. On Windows the palette is opened with Ctrl+K, as a person would. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The update's end-to-end check on a real Windows desktop failed with "could not replace lokalbot.exe: The process cannot access the file because it is being used by another process", and the whole update gave up on the first try. Master passed that check on the same step, so nothing shows this had reached users, but anything that opens the file without allowing its rename can cause it: antivirus after a new file, or reading a running executable's version details, as LokalBot does to name the focused app. Each rename on Windows now keeps trying for up to 30 s on a sharing violation, and says when it waited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the Windows and Linux app close to feature parity with the Mac. It adds selection actions, spoken summaries, remembered speakers, Files, screen search by meaning, the overnight review, Personal Context, coding-agent sessions, note and daily exports, routines, library health, retention review, the Actions, People and Projects workspaces, agent handoff, the command palette, Settings Overview and search, agents changing settings behind the Mac's approval, and hosting paired phones and tablets. It also closes many smaller gaps in dictation, autocomplete, models and recording, and fixes bugs that had reached users (listed under Risk).
It isn't full parity. Still different from the Mac:
.doc, RAW, or scans stored as JBIG2, CCITT or JPEG 2000. Video frames, HEIC and AVIF need ffmpeg, and results open in their default app.Validation
On Linux, from
LinuxWindows/, on the final code. Tests ran with a temp home and a private session bus:From the repo root,
python3 -m unittest discover -s Scripts/testsran 162 tests. 4 error because they need macOS tools (xcrun,afconvert,say). None of the four's sources changed here.Earlier on this branch, before the final Files commit and master merge, the merged app was also started on a demo library under Xvfb with a window manager. Every page and Ctrl+K opened with no panics, and Settings and Ask were checked in Arabic (right-to-left) and Serbian.
Workers also ran these for real under Xvfb, in temp libraries:
kill -9recovery.Never run, so CI and manual testing need to cover these:
Nobody has reviewed this line by line: three independent read-only audits checked it against the Swift, and their findings were fixed. The 589 new strings in 23 languages are machine-assisted and need native-speaker review.
Changed test expectations
lokalbot-cliagent_text_names_only_settings_this_app_has: its list of Mac-only wording is now empty and the loop is gone. Those commands and Personal Context exist here now, so naming them is correct.pages/ask/scope.rsscreen_memory_joins_unbound_questions→every_source_joins_unbound_questions: unbound questions now include Activity and Files. The old!include_activityasserted a gap: Activity wasn't offered, though the README claimed it.lokalbot-enginerestricted_questions_are_told_apart: narrowing by Activity, Files, screens or app now counts as restricted. The old test passed with Activity off because it predated those sources; the Mac's rule isscopes == defaultswith no bindings.lokalbot-speechdrops_mic_copies_of_remote_speechandsimilarity_is_in_order_coverageremoved withbleed.rs: the old code deleted mic rows on 80% word overlap, which could delete real speech. As on the Mac, words now only marksuspectedEcho, and removal needs waveform proof (echo_evidence.rs).lokalbot-engineremembered_turns_stay_out_of_model_history→ corefailed_stopped_and_remembered_turns_stay_out_of_history: the function moved, and failed and stopped turns are now also excluded, as on the Mac.other_names_are_cleaned: moved withclean_other_namestolokalbot-core, unchanged.hidden_paths_do_not_ask_for_a_pass→a_watcher_event_says_what_it_can_and_the_path_says_the_restandchange_filtertests: hidden paths are now one of several rules, matchingFileChangeFilter.lokalbot-platformshortcuts.rs: Ctrl+Alt alone is allowed where chords work. The Mac allows two modifiers alone, and the old refusal was a gap.lokalbot-platformtray tests: labels changed for the new items, and the copy row has a preview and an Earlier submenu, as on the Mac.lokalbot-aiqwen_language_name("sr"): now Serbian, matching the Mac.presets_round_tripgoes throughpatch(), because presets can now leave fields alone.pages/settings/catalog.rs: no longer treats "obsidian" and "sessions" as absent, because those settings exist now.read_projectsgoes throughread_work_memory, which refuses retracted items. Reading the file raw was a bug.lokalbot-coreembeddings.rs:hybrid_searchassertions removed along with that unused function.search_files. The retention fixture usesIF NOT EXISTS, because core now creates that table.scripts/tests/test_localizations.pynow scans every crate. It missed 45 strings inlokalbot-coreandlokalbot-engine, which stayed English in every language; it failed before those were translated.FileSearchServiceTests.testRemovingAFolderDropsItsFilesAndTurningOffDeletesTheIndex: waits up to 20 s for the index to go, not 300 ms. It failed on CI because deleting happens on other queues.FileSearchServiceTests.testOnlyAChangeThatCanAlterTheIndexStartsAPass: counts from a settled baseline, and a change that matters must start at least one more pass, not exactly one. It failed on master because a write from just before the FSEvents stream most likely started a pass; that cause is inferred from the timing, since this can't run off a Mac.Linked issues
Refs #425 (the Kokoro pin, merged; the Rust app pins the same file).
Risk / rollout notes
Behaviour that changes on update for existing Windows and Linux users:
http://to any non-loopback server, including LAN and Tailscale, even once approved. Anyone relying on that must move to HTTPS. This matches the Mac.chat-key. Plaintext ones open and are then re-sealed. Without a reachable credential store, new chats stay in memory and old ones stay plaintext, with a banner.codingAgentEvidenceEnabled: truewithout asking, so an update must not start reading~/.claudeand~/.codex.codingAgentEvidenceConfirmedgates this, and a library moved from a Mac starts unconfirmed.Windows bugs CI found in this work, fixed here:
~\Code, and the coding-agent rule didn't expand it, so it matched nothing.IpcServerhad the same bug.lokalbot.exefor a moment (os error 32). Each rename now keeps trying for up to 30 s. What held it isn't known, and no run on master showed this. The new testwindows_waits_for_a_file_held_for_a_momenthasn't been confirmed failing with the fix undone.Bugs fixed that had reached users:
read_projectscould surface retracted projects.PRIVACY.mdhad a paragraph duplicated by an old merge.Dependencies added, all accepted by
about.toml, withLICENSES/rust-crates.mdregenerated:spellbook(MPL-2.0),mdns-sd(Apache-2.0 or MIT),lopdf,pdf-extractandnotify(MIT or Apache-2.0), plus transitive crates. Download size wasn't measured.Coordination:
claude/nervous-hypatia-9841db) renames the phones' "Pair with a Mac" button. Whichever lands second must updatepages/settings/devices.rsto match and regeneratecatalogs.rs.claude/ecstatic-bouman-4462df) must not publish until a release includes this.Mergeable as one change, but large: 430 files. The commits separate code, translations and docs to make it easier to read.
🤖 Generated with Claude Code