Skip to content

Bring the Windows and Linux app close to parity with the Mac - #430

Merged
stevyhacker merged 10 commits into
masterfrom
claude/linux-windows-macos-parity-f0cd40
Nov 3, 2026
Merged

stevyhacker merged 10 commits into
masterfrom
claude/linux-windows-macos-parity-f0cd40

Conversation

@stevyhacker

@stevyhacker stevyhacker commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Summary

Brings the Windows and Linux app close to feature parity with the Mac. It adds selection actions, spoken summaries, remembered speakers, Files, screen search by meaning, the overnight review, Personal Context, coding-agent sessions, note and daily exports, routines, library health, retention review, the Actions, People and Projects workspaces, agent handoff, the command palette, Settings Overview and search, agents changing settings behind the Mac's approval, and hosting paired phones and tablets. It also closes many smaller gaps in dictation, autocomplete, models and recording, and fixes bugs that had reached users (listed under Risk).

It isn't full parity. Still different from the Mac:

  • Gmail in meeting briefs isn't ported. It needs a Google OAuth client registered for desktop apps.
  • Autocomplete in other apps doesn't work on Wayland, and screen text recognition reads Latin script only. Bring autocomplete to other apps on Wayland as an input method #432 and Read screen text in more than Latin script on Linux and Windows #431 fix both on top of this branch.
  • Remembered speakers only suggest names, because the Mac's thresholds aren't calibrated for this voice model on real calls.
  • Files doesn't read .doc, RAW, or scans stored as JBIG2, CCITT or JPEG 2000. Video frames, HEIC and AVIF need ffmpeg, and results open in their default app.
  • Mac-only speech runtimes (Granite, Nemotron and others) aren't available.

Validation

On Linux, from LinuxWindows/, on the final code. Tests ran with a temp home and a private session bus:

cargo fmt --all -- --check                                      # exit 0
cargo clippy --workspace --all-targets --locked -- -D warnings  # exit 0
cargo test --workspace --locked                                 # 2182 passed, 0 failed, 23 ignored
cargo check --target x86_64-pc-windows-gnu --workspace --all-targets --locked   # exit 0
python3 -m unittest discover -s scripts/tests                   # OK
scripts/third-party-licenses.sh --check                         # up to date

From the repo root, python3 -m unittest discover -s Scripts/tests ran 162 tests. 4 error because they need macOS tools (xcrun, afconvert, say). None of the four's sources changed here.

Earlier on this branch, before the final Files commit and master merge, the merged app was also started on a demo library under Xvfb with a window manager. Every page and Ctrl+K opened with no panics, and Settings and Ask were checked in Arabic (right-to-left) and Serbian.

Workers also ran these for real under Xvfb, in temp libraries:

  • Selection actions: read, replace, password refusal.
  • A real recording through SIGTERM, Ctrl+Q, window close, tray Quit and kill -9 recovery.
  • The per-app audio tap, on a private PipeWire.
  • The phone host, loopback only: QR scanned from a screenshot, paired with the test client, synced, revoked.
  • Files, against the real embedding model on CPU.
  • Agent settings approval: Allow, Approve and Deny clicked.
  • Ask's question boundary: a mock server's log shows wider answers excluded from narrowed questions.

Never run, so CI and manual testing need to cover these:

  • Windows by hand. The Windows CI job now runs the whole test suite on real Windows, and the desktop checks capture every page, run autocomplete in Notepad, screen capture with OCR, and an update end to end. SMTC, process loopback and dictation haven't run on Windows.
  • Wayland, PulseAudio itself, real phones, LAN and mDNS, real meeting calls, dictation end to end with a real microphone and model, and audible playback.
  • Many new dialogs were only rendered or unit-tested, never clicked through.

Nobody has reviewed this line by line: three independent read-only audits checked it against the Swift, and their findings were fixed. The 589 new strings in 23 languages are machine-assisted and need native-speaker review.

Changed test expectations

  • lokalbot-cli agent_text_names_only_settings_this_app_has: its list of Mac-only wording is now empty and the loop is gone. Those commands and Personal Context exist here now, so naming them is correct.
  • pages/ask/scope.rs screen_memory_joins_unbound_questions → every_source_joins_unbound_questions: unbound questions now include Activity and Files. The old !include_activity asserted a gap: Activity wasn't offered, though the README claimed it.
  • lokalbot-engine restricted_questions_are_told_apart: narrowing by Activity, Files, screens or app now counts as restricted. The old test passed with Activity off because it predated those sources; the Mac's rule is scopes == defaults with no bindings.
  • lokalbot-speech drops_mic_copies_of_remote_speech and similarity_is_in_order_coverage removed with bleed.rs: the old code deleted mic rows on 80% word overlap, which could delete real speech. As on the Mac, words now only mark suspectedEcho, and removal needs waveform proof (echo_evidence.rs).
  • lokalbot-engine remembered_turns_stay_out_of_model_history → core failed_stopped_and_remembered_turns_stay_out_of_history: the function moved, and failed and stopped turns are now also excluded, as on the Mac.
  • other_names_are_cleaned: moved with clean_other_names to lokalbot-core, unchanged.
  • hidden_paths_do_not_ask_for_a_pass → a_watcher_event_says_what_it_can_and_the_path_says_the_rest and change_filter tests: hidden paths are now one of several rules, matching FileChangeFilter.
  • lokalbot-platform shortcuts.rs: Ctrl+Alt alone is allowed where chords work. The Mac allows two modifiers alone, and the old refusal was a gap.
  • lokalbot-platform tray tests: labels changed for the new items, and the copy row has a preview and an Earlier submenu, as on the Mac.
  • lokalbot-ai qwen_language_name("sr"): now Serbian, matching the Mac. presets_round_trip goes through patch(), because presets can now leave fields alone.
  • pages/settings/catalog.rs: no longer treats "obsidian" and "sessions" as absent, because those settings exist now.
  • Upcoming-project fixture: now needs provenance, because read_projects goes through read_work_memory, which refuses retracted items. Reading the file raw was a bug.
  • lokalbot-core embeddings.rs: hybrid_search assertions removed along with that unused function.
  • MCP tool count 14 → 15 for search_files. The retention fixture uses IF NOT EXISTS, because core now creates that table.

scripts/tests/test_localizations.py now scans every crate. It missed 45 strings in lokalbot-core and lokalbot-engine, which stayed English in every language; it failed before those were translated.

  • FileSearchServiceTests.testRemovingAFolderDropsItsFilesAndTurningOffDeletesTheIndex: waits up to 20 s for the index to go, not 300 ms. It failed on CI because deleting happens on other queues.
  • FileSearchServiceTests.testOnlyAChangeThatCanAlterTheIndexStartsAPass: counts from a settled baseline, and a change that matters must start at least one more pass, not exactly one. It failed on master because a write from just before the FSEvents stream most likely started a pass; that cause is inferred from the timing, since this can't run off a Mac.

Linked issues

Refs #425 (the Kokoro pin, merged; the Rust app pins the same file).

Risk / rollout notes

Behaviour that changes on update for existing Windows and Linux users:

  • The overnight review starts running, on by default as on the Mac, reading from yesterday only. It waits for mains power and uses remote Think only for an approved origin.
  • Think and Agent Mode refuse plain http:// to any non-loopback server, including LAN and Tailscale, even once approved. Anyone relying on that must move to HTTPS. This matches the Mac.
  • Ask chats are now sealed under a new chat-key. Plaintext ones open and are then re-sealed. Without a reachable credential store, new chats stay in memory and old ones stay plaintext, with a banner.
  • Coding-agent sessions need an explicit opt-in here, unlike on the Mac. Installs had saved codingAgentEvidenceEnabled: true without asking, so an update must not start reading ~/.claude and ~/.codex. codingAgentEvidenceConfirmed gates this, and a library moved from a Mac starts unconfirmed.
  • Dictation's window context is off on new installs.

Windows bugs CI found in this work, fixed here:

  • A folder rule chosen on Windows is saved as ~\Code, and the coding-agent rule didn't expand it, so it matched nothing.
  • Stopping a named-pipe server could hang if a client had already left. The already-shipped IpcServer had the same bug.
  • An update gave up if something held lokalbot.exe for a moment (os error 32). Each rename now keeps trying for up to 30 s. What held it isn't known, and no run on master showed this. The new test windows_waits_for_a_file_held_for_a_moment hasn't been confirmed failing with the fix undone.

Bugs fixed that had reached users:

  • Saving settings dropped keys this port didn't model, so a library from a Mac lost them.
  • Microphone pickers were always empty.
  • Closing the window during a recording lost its end time and job.
  • Mic transcript rows were deleted on word overlap alone.
  • Debug logs held typed text and suggestions.
  • Picture vectors outlived their pixels; deleted sources left generated journals; read_projects could surface retracted projects.
  • PRIVACY.md had a paragraph duplicated by an old merge.

Dependencies added, all accepted by about.toml, with LICENSES/rust-crates.md regenerated: spellbook (MPL-2.0), mdns-sd (Apache-2.0 or MIT), lopdf, pdf-extract and notify (MIT or Apache-2.0), plus transitive crates. Download size wasn't measured.

Coordination:

  • The phone-copy branch (claude/nervous-hypatia-9841db) renames the phones' "Pair with a Mac" button. Whichever lands second must update pages/settings/devices.rs to match and regenerate catalogs.rs.
  • The website update (claude/ecstatic-bouman-4462df) must not publish until a release includes this.

Mergeable as one change, but large: 430 files. The commits separate code, translations and docs to make it easier to read.

🤖 Generated with Claude Code

stevyhacker and others added 5 commits November 2, 2026 21:24
Ports what the Mac has and the Rust app lacked: selection actions; the
dictation and autocomplete gaps (delivery guard, Compose context, live
transcript, accept keys, macros, statistics, learning, an autocomplete server);
spoken summaries; remembered speakers; Files; screen search by meaning; the
overnight review; Personal Context; coding-agent sessions; note and daily
exports; routines; library health; retention review; the Actions, People and
Projects workspaces; agent handoff; the command palette; Settings Overview and
search; agents changing settings, behind the Mac's approval; and hosting paired
phones and tablets.

Also fixes bugs that reached users. Saving settings dropped keys this port
didn't model, so a library from a Mac lost them. Microphone pickers were always
empty. Closing the window during a recording lost its end time and job. Mic
transcript rows were deleted on word overlap alone. Debug logs held typed text.
Think accepted plain HTTP to a server off this computer, where the Mac requires
HTTPS. Picture vectors outlived their pixels, and deleted sources left generated
journals and work memory behind.

Coding-agent sessions need an explicit choice here, unlike on the Mac: installs
already saved that key as true without asking, so an update must not start
reading them silently. Remembered speakers only suggest names, because the
Mac's thresholds aren't calibrated for this voice model on real calls.

Not ported: Gmail in meeting briefs, and Mac-only speech runtimes. All Windows
code is only type-checked, and Wayland, real phones and real calls were never
run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
589 strings into the 23 other interface languages, machine-assisted like the
rest of the desktop catalog and in need of native-speaker review. The two hints
that show the "Remember" trigger keep it in English or Serbian, the only words
the parser recognises.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moves features out of the Mac-only lists, and says what differs where it does.
Also removes a paragraph in PRIVACY.md that an old merge had duplicated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and Windows

Follows #424 and #426 on the Mac: every pass walks the chosen folders again, so
a change the crawl would leave out no longer starts one. It leaves out tmp and
temp folders too, while a folder chosen on its own is still read whole.

Unlike FSEvents, the watchers here often don't say whether a path is a file or
a folder, so the path answers where it still exists. When nothing can tell, the
change counts, unless it's in a hidden folder.

Also restores the test of clean_other_names, lost when that function moved to
lokalbot-core.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
lokalbot b07d573 Commit Preview URL

Branch Preview URL
Nov 03 2026, 01:32 AM

The folder picker saves a rule under the home folder as `~\Code\client`, but only
`~/` was expanded, so on Windows that exclusion matched nothing and sessions from
an excluded folder were still read. A home path with backslashes was also left
unnormalized.

Found by the first real Windows CI run, which failed on a test that fed Unix
paths to `Path::join`; that test now uses each platform's separator. The Windows
job now runs every crate, so one run shows every failure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stevyhacker and others added 4 commits November 3, 2026 00:58
Stopping a pipe server woke its accept with a connection it closed at once. A
Windows pipe listener skips a client that has already left, so if the thread
hadn't reached ConnectNamedPipe yet, accept kept waiting and join waited on it
forever. That could freeze the app on quit, or when agent settings control is
turned off. The wake-up connection now stays open until the thread has gone.
IpcServer, which already shipped, had the same bug.

Found by the first full Windows CI run, where the test hung until the job timed
out. Also fixes two tests that run failed: one fed a Unix path to Path::join, and
one compared days across midnight on the runner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both failed on and off in xcodebuild test on master and on pull requests.

Turning Files off deletes the index on the reader's and worker's queues, and
the test gave that 300 ms. It now waits up to 20 s for the folder to go.

FSEvents can report notes.txt, written just before its stream began, and that
starts a second pass during the wait that should show none. The test now
outlasts the watcher's latency before it counts, and again after the writes
that can't alter the index: with a 2 s latency, the old 1 s wait could end
before those writes had been reported at all.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Windows and Linux checks photographed the app's older pages only, so
Files, Devices and Personal Context had never been seen on a real desktop.
On Windows the palette is opened with Ctrl+K, as a person would.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The update's end-to-end check on a real Windows desktop failed with "could not
replace lokalbot.exe: The process cannot access the file because it is being
used by another process", and the whole update gave up on the first try.
Master passed that check on the same step, so nothing shows this had reached
users, but anything that opens the file without allowing its rename can cause
it: antivirus after a new file, or reading a running executable's version
details, as LokalBot does to name the focused app.

Each rename on Windows now keeps trying for up to 30 s on a sharing violation,
and says when it waited.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stevyhacker
stevyhacker merged commit 564bc51 into master Nov 3, 2026
16 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant