Skip to content

Stop attaching .sha256 files to releases - #435

Merged
stevyhacker merged 1 commit into
masterfrom
claude/lokalbot-artifact-simplify-5ffea4
Nov 3, 2026
Merged

stevyhacker merged 1 commit into
masterfrom
claude/lokalbot-artifact-simplify-5ffea4

Conversation

@stevyhacker

Copy link
Copy Markdown
Owner

Summary

Releases stop attaching the seven .sha256 files, which takes the asset list from 18 files to 11. GitHub already shows each file's SHA-256 on the release page and returns it as digest in the API, so the files only repeated it. The Homebrew tap already reads digest, and the winget, AUR and apt/dnf steps now do too.

Validation

Run against the published releases, with the steps taken from the workflow files as written:

  • linux-repos.yml, on the Ubuntu box (24.04, same as the runners): the latest release's archive and v0.12.1's .deb and .rpm download and verify. I left out the unchanged rpm -qp line because the box has no rpm.
  • Refused by the same check line: a tampered .deb, a folder with none of the files, a null digest and an empty digest list.
  • update-aur.sh 0.12.1: PKGBUILD and .SRCINFO get 317cef0e…, which equals the published .sha256. A release that doesn't exist and a release without the file both fail.
  • winget.yml digest check, in local pwsh 7.5: the real 0.11.0 manifest passes, and GitHub's digest equals v0.11.0's published .sha256. A wrong hash and a file not on the release are both refused.
  • Static checks: Scripts/tests/test_ci_pipeline.py and test_release_signing_boundary.py pass (40 tests, OK). shellcheck is clean on the three changed shell scripts, the PowerShell script parses, and the six changed workflows parse as YAML.

Not run yet:

  • The real Linux and Windows packaging and the winget install on Windows. This PR's paths trigger linux-windows-release.yml, linux-repos.yml, winget.yml and aur.yml.
  • The upload steps in release.yml, which only run on a real tag. The first proof is the next release's file list.

Changed test expectations

None.

Linked issues

None.

Risk / rollout notes

  • Anyone's own script that downloads a .sha256 file will break from the next release. The v0.11.3 notes told people about these files, so the next release's notes should say they're gone. Each one got 1–5 downloads per release, and some of those were this repo's own CI.
  • No security change: the .sha256 files and GitHub's digest both come from GitHub, and neither is signed. In-app updates still check their signed feeds.
  • Published releases keep their files. Older releases have digest too (checked on v0.11.0), so the winget check on older manifests needs no special case.
  • LokalBot.mcpb isn't touched. It was uploaded to v0.12.1 by hand and isn't in the pipeline, so the next release won't have it unless someone uploads it again.

GitHub shows each release file's SHA-256 on the release page and returns it
as digest in the API, so the seven .sha256 files only repeated it. Removing
them takes the asset list from 18 files to 11.

The Homebrew tap already reads digest. The winget, AUR and apt/dnf steps now
read it too. Older releases have digest as well, so those steps work on them
without a special case.
@stevyhacker
stevyhacker marked this pull request as ready for review November 3, 2026 13:59
@stevyhacker
stevyhacker merged commit 33e207e into master Nov 3, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant