Repository navigation
Stop attaching .sha256 files to releases - #435
Merged
Merged
Conversation
GitHub shows each release file's SHA-256 on the release page and returns it as digest in the API, so the seven .sha256 files only repeated it. Removing them takes the asset list from 18 files to 11. The Homebrew tap already reads digest. The winget, AUR and apt/dnf steps now read it too. Older releases have digest as well, so those steps work on them without a special case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases stop attaching the seven
.sha256files, which takes the asset list from 18 files to 11. GitHub already shows each file's SHA-256 on the release page and returns it asdigestin the API, so the files only repeated it. The Homebrew tap already readsdigest, and the winget, AUR and apt/dnf steps now do too.Validation
Run against the published releases, with the steps taken from the workflow files as written:
linux-repos.yml, on the Ubuntu box (24.04, same as the runners): the latest release's archive and v0.12.1's.deband.rpmdownload and verify. I left out the unchangedrpm -qpline because the box has norpm..deb, a folder with none of the files, anulldigest and an empty digest list.update-aur.sh 0.12.1:PKGBUILDand.SRCINFOget317cef0e…, which equals the published.sha256. A release that doesn't exist and a release without the file both fail.winget.ymldigest check, in local pwsh 7.5: the real 0.11.0 manifest passes, and GitHub's digest equals v0.11.0's published.sha256. A wrong hash and a file not on the release are both refused.Scripts/tests/test_ci_pipeline.pyandtest_release_signing_boundary.pypass (40 tests, OK). shellcheck is clean on the three changed shell scripts, the PowerShell script parses, and the six changed workflows parse as YAML.Not run yet:
linux-windows-release.yml,linux-repos.yml,winget.ymlandaur.yml.release.yml, which only run on a real tag. The first proof is the next release's file list.Changed test expectations
None.
Linked issues
None.
Risk / rollout notes
.sha256file will break from the next release. The v0.11.3 notes told people about these files, so the next release's notes should say they're gone. Each one got 1–5 downloads per release, and some of those were this repo's own CI..sha256files and GitHub's digest both come from GitHub, and neither is signed. In-app updates still check their signed feeds.digesttoo (checked on v0.11.0), so the winget check on older manifests needs no special case.LokalBot.mcpbisn't touched. It was uploaded to v0.12.1 by hand and isn't in the pipeline, so the next release won't have it unless someone uploads it again.