Repository navigation
Project audit fixes, and Live Radar on the Think model - #474
Merged
Merged
Conversation
Defects: - get_meeting's "from" time could overflow and stop the app. - Live answers' code tools read hidden, vendored and secret-looking files that git tracks. - Hand off packages were deleted only when another handoff happened. - The overnight review read the sample meeting. - "Go to Today" could stay on the Actions review. - Voice samples of meetings folded into a merge never expired, and the hourly pass rewrote every expired journal again. - Reprocessing a meeting whose notes repeat an action stopped the app. - Focus leaving a shown suggestion left autocomplete "ready", which skipped the next field's warm-up, and a focus change replaced a recording's pause label. - ask, reply and ask_library waited a minute before reporting a closed app. - install-skill could not find its bundle when run by bare name from PATH. - A refused streamed request lost the provider's reason. - The audio monitor took playback from the Dev and UI Test Host builds for a meeting candidate. - "Menu bar only" could read the old setting; a file-search window kept its player after closing. The command-line tool prints its code before an access refusal ([access_disabled], [files_access_disabled], ...), and get_meeting refuses an include value it does not know, as on Windows and Linux. Also: work done once instead of per call (clock stamps, citation patterns, the link detector, list flags, saved-moment notes, the launch relink query), unused code and two unused views removed, stale comments corrected, the Lint failure from the hackathon merge fixed, a test helper that skipped where it should fail, and a test whose random input had no seed.
Live Radar, its screen answers and its live answers used Meta's Model API, a hackathon requirement. They now run on the Think model from Settings → Models, through ThinkExecution like notes and Ask, so they follow its model, server and consent. - ThinkChat turns the radar's structured requests and the live answers' tool loop into TextEngine calls. - Screen answers give the model each crop's text, not the picture. - "Offer Live Radar during meetings" (Settings → Meetings → Live Radar) turns the feature on. It is off for new installs; settings that had approved api.meta.ai keep it on. - The radar and live-answer model pickers are gone. Meta Muse keeps the approval, the key, fast live text and Follow-through's model. - Cost is shown only where a meeting has one. - The UI-test host keeps Meta's request format for the hosted film test. Follow-through and fast live text still use Meta's models.
- One unreadable setting no longer resets every setting. - A malformed JPEG no longer stops file indexing, and an impossible recorded length no longer panics. - A hung audio system at recording start no longer hangs the engine. - A cancelled dictation no longer blocks day digests and overnight reviews. - A model counts as ready only once its download has finished, deleting a model removes its digest file, and a resumed download checks free space. - An approved plain-HTTP autocomplete server on the private network works, and a server that does not stream is asked once. - The recording in progress cannot be deleted. - A click on a notification's body reaches its action on Linux. - Pasted dictation stays out of clipboard history. - A phone connection that trickles bytes ends at the handshake deadline. - In-app updates refresh the KDE input-method entry, and install.sh --uninstall removes the agent skill and the login entry. - The command-line tool prints its code before an access refusal, and get_meeting refuses an include value it does not know. Also: older library reads no longer replace newer ones, recording a shortcut pauses the global shortcuts, the recording-health file is saved every 30 s again, and unused code, icons and two dependencies are removed.
- Android: the People list no longer crashes on a date without a time zone. - Android: a question queued for later shows its answer. - Android: search results mark the matched words instead of printing « ». - iOS: pairing from pasted text works when the text holds more than the link. - iOS: App Lock covers the iPad's meeting window. - Both: a pairing code is accepted for the 120 s after expiry that the computer allows. - Unused code and an unused dependency removed; protocol documents corrected.
- Site: corrected claims (file import, model sizes, MCP tools on Windows and Linux, Granite Speech 5, how agent access is turned on), footer links, and 620 lines of unused styles and 86 of unused script removed. Every page renders the same before and after. - The local preview server serves pages as production does. - Documents: settings locations, the port's external-agent switches, model notices, the Chinese README's facts about the port, release steps. - CI: starting the macOS 26 UI run by hand no longer fails at the build job, the scheduled UI run and a release dispatch no longer cancel each other, and the Linux/Windows workflow runs when files its tests read change. - Scripts create the vendor folders XcodeGen needs before a first build. - Six unreferenced images removed; the MCP bundle names www.lokalbot.com.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lokalbot | b2abe13 | Commit Preview URL Branch Preview URL |
Nov 10 2026, 09:33 AM |
stevyhacker
marked this pull request as ready for review
November 10, 2026 08:35
The hosted film test's scripted screen answer matched its words against the first text part of the request, which begins with the meeting's title. In "Launch sync" every question matched "launch", so the Team plan question was answered "Monday, November 3" from the launch plan. The test takes the first screen answer for the conversion one, and failed on "4.1% in September". The rule now reads only the question. The film workflow always ran with live replies, so the scripted path first ran in the required UI suite for PR 427. It failed there and in each of the three runs of that shard since. Two later checks in the test, which no run has reached, now look for their text in any element's label: the commitment's card sits in a lazy grid that may not be built while out of view, and a code source is a button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two things, in five commits (one per area), and a sixth that repairs the hosted film test:
ThinkExecutionlike notes and Ask. Follow-through and fast live text still use Meta's models.What users would notice most:
get_meetingwith a hugefrom); reprocessing a meeting whose notes repeat an action could stop the app; live answers' code tools read hidden, vendored and secret-looking files; Hand off packages outlived their 7 days; the overnight review read the sample meeting; voice samples of merged meetings never expired;askwaited a minute before reporting a closed app; autocomplete skipped warming up the next field after focus left a suggestion.Both command-line tools now print the error code before an access refusal (
[access_disabled],[files_access_disabled], …), which the agent skill already tells agents to look for, and both MCP servers refuse anincludevalue they do not know.Validation
Mac, on the final tree:
Windows and Linux, on the Ubuntu box, whole workspace, with the regenerated catalogs:
Phones:
Site and scripts:
UI suite, hosted, on
caab609: every shard passed exceptUI functional-1, whereHackathonFilmUITests.testFilmLiveRadarAndFollowThroughfailed at its4.1% in Septembercheck. Its settings steps undersettings.liveRadar.*passed.b2abe13): the rule reads only the question. Replayed outside the UI with the app's own term, crop and quote code on the two fixture captures: before, the Team plan question gets "Monday, November 3"; after, it gets no answer, the conversion question gets "4.1% in September" and the launch question "Monday, November 3".CODE_SIGNING_ALLOWED=NO bash Scripts/ui-tests.sh --build-onlysucceeds with the fix. The test itself runs only in CI.Not verified:
4.1% in Septemberhave never run with scripted replies, so this push is their first run.#[cfg(windows)]was edited.install.sh --uninstallwas syntax-checked only.Changed test expectations
Mac:
MeetingRadarTests/testRadarNeedsApprovalBeforeAnythingIsSent→testRadarIsOffUntilItIsTurnedOnInSettings: the radar was unavailable untilapi.meta.aiwas approved and a key saved → it is unavailable until "Offer Live Radar during meetings" is on.Why the old expectation no longer holds: Live Radar no longer sends to Meta, so Meta's approval is not what gates it. A remote Think server still needs its own approval, which the Think engine checks.
RadarScreenAnswersTests/testRadarAnswersACaughtQuestionFromTheScreenAndSavesTheCrop: the model was sent the crop as a picture and the answer had a cost → it is sent the crop's text, no picture, and the cost is 0.Why: a Think model may read text only. The picture path is kept for the hosted film test and has its own test,
testAModelThatReadsPicturesIsSentTheCropAndItsCostCounts, with the old assertions.MeetingRadarTests/testPassesSendOnlyNewLines…: same assertions. It now names Muse Spark as the model so its cost assertion still uses Meta's prices.DailyMemoryExportServiceTests, helperwrittenURL(9 tests): an export that was not written skipped the test → it fails it. The old helper hid a regression as a skip.MeetingIntegrityTests: six calls drophostReconnectGrace: 15. The parameter was ignored and is removed. No assertion changed.RedesignContractTests/testLazilyFilledScreenGroupsMatchFillingEveryHit: same assertions; the random input comes from a seed that each failure names.AskLibraryEngineTests, helpermakeEngine: says the app is running, so the wake tests still reach the wake now that a closed app is reported at once.HackathonFilmUITests/testFilmLiveRadarAndFollowThrough: the checks for "Send the revised pricing deck" and "AppSettings.swift" looked for a static text → they look for the text in any element's label.Why: the commitment's card is in a lazy grid below the cards that need attention, which may not be built while out of view (the floating panel lists it as a row either way), and a code source is a button. No run has reached either check, so this is a precaution, not a failure that was seen.
LokalBotTests/Fixtures/upgrade/{0.6.2,0.7.2,0.8.5,0.9.0,0.9.1,0.9.2,0.9.3,0.10.10}/library/lokalbotv3.sqlite-waland-shmremoved. Every-walwas 0 bytes.UpgradeMigrationTestspass.Windows and Linux:
lokalbot-cli/tests/cli.rs,brief_names_cli_commands_where_get_briefing_names_tools: "Commands: search, get, list, actions, and people." → "Commands: search, get, list, actions, people, and ask while the app runs."Why the old expectation was wrong:
askis a command on the port too, and the Mac's brief already listed it.lokalbot-platform/tests/live_dbus.rs,notification_actions_reach_the_callback(ignored by default): the actions offered now end with"default", "LokalBot".Why: a notification server reports a click on the body only for a notification that registered the default action, so the callbacks for "open the update" and "review this request" never ran.
Android:
pairing/PairingLinkTest.kt: the expired case wasnow - 1→now - 121.ui/ViewModelTest.kt: the expired link wasnow - 10→now - 600.Why the old expectation was wrong: the phone refused a code the moment it expired on the phone's clock, so the 120 s the computer allows for a fast clock never applied.
now - 1andnow - 120are asserted valid in a new test.Linked issues
None closed. Issue 458 (Parakeet downloads on Windows and Linux) is not fixed here: upstream re-exported both models, and moving the pin ships files nobody here has run.
Risk / rollout notes
liveRadarEnabled, off by default. Saved settings without the key decode it as on whenhttps://api.meta.aiis in the approved origins, so people who used Live Radar keep it. For them Live Radar now reads with their Think model: on this Mac if Think is local, or at the Think server they approved. PRIVACY.md says so.museRadarModelandliveAnswersModel. Saved values are ignored. The Windows and Linux settings file keeps unknown Mac keys as before.get_meetingwith an unknownincludevalue is an error. An agent that matched the old bare message would need the code instead; the shipped skill already names the codes.defaultaction labelled "LokalBot". Most desktops never show the label; one that lists every action would show it.build.ymlandui-tests.ymlempties the compiler cache once, so the next Build and UI runs compile from scratch.