Repository navigation
Open audit items: privacy promises kept, Follow-through on Think, Parakeet repinned - #478
Merged
Merged
Conversation
…odel Privacy and consent: - A paired phone's Ask reads only the shared meetings and no Timeline day before the shared window, never the sample meeting. An empty shared set now means nothing is readable; it used to mean everything. - Revoking a transcription server, or choosing an on-device model, stops the remaining uploads of the meeting in progress. The meeting restarts on the current settings or waits. - On the Claude plan the schema and prompt go over stdin, not the `claude` command line. A reply that ignores the schema is an error. - Revoking an origin ends a running Agent Mode turn. An open Agent task holds the built-in model only during a turn. - The environment variable that wrote screen-derived model output to debug.log is gone. Follow-through runs on the Think model from Settings → Models, through ThinkChat, like Live Radar. Its model picker and `museFollowThroughModel` are removed; the Meta Muse section now covers fast live text only. The UI-test host keeps Meta's request format for the film test. Windows and lists: - List columns open at their set width and no longer jump to maximum on selection. The system-wide Ask window opens with its field focused. - On macOS 26, right-to-left languages keep the window's splits left-to-right, where the mirrored window crashed Settings. - The floating Live Radar panel hides when its setting is turned off. Also: a failed screen-retention pass is retried within the hour, up to three times; `list_meetings` takes `until`; file search widens when filters drop hits; smaller fixes; unused code removed (CotypingABComparison, AskScopeReconciler, AskEscalationScope, PromptSectionBudget). Strings: 6 added, 3 changed, 5 removed, in all 24 languages.
- `Scripts/ci/unit-skips.json` names the 58 opt-in tests that may skip, with a reason for each group. `Scripts/ci/unit-skips.py` fails the unit job and `Scripts/unit-tests.sh` on any other skip, and the hosted job also fails when a listed test is missing from the results. - The run-on standup replay, which had skipped for over a month, now runs on recordings from the last nightly run that recorded. - A helper that turned a regression into skipped tests now fails. - The contrast audit measures rendered text, so two labels that pass 4.5:1 no longer fail on macOS 26. - UI shards are planned from two green runs: 1,230 s and 1,226 s. - Three timing-sensitive unit tests wait for their condition instead of sleeping a fixed time.
…r a meeting - Parakeet v3 and v2 are pinned to upstream's re-exported archives. Old and new files gave the same text on every clip through the port's recognizer. Installs of the previous files still count as installed. - Recordings parked "waiting for models" are processed within about 5 s of the models arriving, without repeating a finished transcription. A job that waited only for an automatic summary goes on when automatic summaries are turned off. - The speech model is shared per span of audio, so a dictation no longer waits for a whole meeting. Dictation ends when the microphone is lost. - Accepting a non-ASCII suggestion over AT-SPI inserts the right text on GTK 3/4 and Qt 5/6: offsets are counted per toolkit. - A calendar link over http:// is refused unless it is on this computer, with the reason shown. - On the Claude plan the schema goes over stdin, not the command line. - While an Agent Mode task is open on the built-in model, choosing another built-in model is refused with a message; it used to make every Think job wait forever. - A click on a notification's body is handled on Windows (not run). - `list_meetings` takes `until`; file search reads every matching passage until it has the files asked for; smaller fixes. Strings: 4 changed, 5 added, in all 24 languages; catalogs regenerated.
- iOS: App Lock covers sheets, the recording screen and alerts with a cover window per scene. While locked, keyboard commands are off and the answer banner shows the question only. - Android: App Lock hides the recents picture and can no longer be skipped when Android restores the app after ending its process. - Meetings page past 1,000 on both apps; Android search covers the whole library, and People, Projects and Timeline lose the same cap. - A change the computer refuses shows "Not changed on your computer" with the computer's reason. - Android keeps a pairing allowed after Cancel. Action changes no longer wait behind queued answers, and iOS Ask no longer waits behind sync.
- Releases attach LokalBot.mcpb and publish to the MCP registry. Both were gated on a repository variable that was never set. - The nightly model-drift check fails and opens an issue when it recorded nothing; it used to report "No drift detected". A pull request without the key skips with a notice. - Two crates compiled into the Mac and phone apps are added to the licence notices, and a CI check keeps the notices complete. - generate_appcast.py refuses the OWNER/REPO placeholder. - The site's privacy page names the autocomplete server, the transcription server and the ChatGPT and Claude plans; the licence line states the AGPLv3 Cotabby portion in the README's words. - The agent skill says which Personal Context items are the user's own words and which were learned. Plugins: Claude 0.3.2, OpenAI 0.2.3. - The hackathon film workflow and its scripts are removed; the film test stays in the UI suite. - Two shell tests that could not fail under bash 3.2 are fixed. - Documents corrected against the code; files nothing references removed.
stevyhacker
marked this pull request as ready for review
November 10, 2026 15:54
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lokalbot | 0e9ee8a | Commit Preview URL Branch Preview URL |
Nov 10 2026, 03:28 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The second pass on the 2026-11-09 project audit. PR 474 left 157 findings open, most of them because they needed a decision. This PR makes those decisions: 76 are fixed, 22 fixed in part, 2 turned out not to be defects, and 57 are left, each with a reason (performance changes nobody could measure here, recovery formats that need a crash on real hardware, typing behaviour that needs the real apps). Over all 283 findings that is 201 fixed, 34 in part, 45 left, 3 not defects.
Five commits, one per area. What a user would notice:
claudecommand line. Revoking an origin ends a running Agent Mode turn. A variable that wrote screen-derived model output todebug.logis gone.http://is refused unless it is on this computer.LokalBot.mcpband lists in the MCP registry. A skipped unit test fails the run unless it is on a checked-in list. The nightly model-drift check no longer reports "No drift detected" when it recorded nothing.Three read-only reviews of the finished diff found 16 defects before anything was committed, among them: a phone's Ask reading every meeting when the shared set was empty, a parked meeting being transcribed twice, and the new Parakeet pins making every existing install count as missing. Fifteen are fixed here; one low one, on Windows, is listed under "Not verified".
Validation
Mac, on the final tree:
Windows and Linux, whole workspace on the Ubuntu box, with the translated catalogs:
Phones:
Site, scripts, distribution:
Not verified:
QuickRecallUITests/testSearchShowsLocalMeetingEvidenceAndInlineAsk,RedesignUITests/testReviewAndSearchAccessibilityInBothAppearances,RedesignUITests/testProjectsHighlightsTheOpenProjectAndSelectionKeepsTheColumnWidth, and the Urdu and Egyptian ArabicSettingsUITests. The right-to-left crash does not reproduce on macOS 27, so its mitigation is unproven.Changed test expectations
Mac:
CompanionAskResponderTests/testMeetingFromADeviceIsAStartingPointNotALimit:_lokalbot_meeting_idswas expected to be nil → every shared meeting's ID.Why the old expectation was wrong: nil is what let a phone's question reach the sample meeting. The test's point, that the focused meeting is not the limit, is kept by asserting the other meeting is in the list.
ClaudePlanEngineTests/testStreamingAndStructuredArguments: expected--json-schema <json>in the arguments → no--json-schema, and--input-format stream-json.Why: the old value put meeting text on the command line, which PRIVACY.md rules out.
CotypingCoordinatorTests/testASuggestionLeftAloneIsTakenDownSoTabReachesTheApp,DictationShortcutTests(two checks),AgentAccessManagerTests(two checks): fixed sleeps of 120 to 600 ms → a wait of up to 3 to 6 s for the condition. Same assertions. The old margins could be eaten by a busy runner.OrphanedLlamaServerReclaimTestshelpers: twoXCTSkip→ a thrown failure. The skips depended on the code under test, so a regression showed as skipped tests.CotypingABBenchmarkTests, two cases inAskRoutingTests, and thePromptSectionBudgetcases inReuseSubsystemsTests.Windows and Linux:
lokalbot-ai/src/plans/claude/tests.rs,arguments_carry_the_mac_isolation_flagsandruns_claude_in_a_private_empty_folder_with_content_on_stdin: arguments ending--json-schema <schema>and a plain-text stdin → stream-json flags, no--json-schema, and stdin as two JSON lines carrying the same text. Same reason as on the Mac.lokalbot-cli/tests/cli.rs,mcp_round_trip: 8 replies → 11, for three newlist_meetingscalls withuntil. No earlier assertion changed.calendar/feed.rs,links_are_normalized_and_redacted_to_their_host:is_err()→ the exact error.autocomplete/atspi.rs,grapheme_counts_become_character_counts: the same three values, asked of the function that replacedchars_in_graphemes.Phones, site and scripts: none. Changed test files only gained tests.
Linked issues
Fixes #458.
Risk / rollout notes
museFollowThroughModeland its picker are removed; saved values are ignored. The Meta Muse approval label now says "meeting audio", which is all the app still sends Meta.initializerequest. A Claude Code that ignores the schema now gives an error where it used to be handed prose.http://stop being fetched on Windows and Linux unless they are on this computer. A saved link is kept and shown as refused, with the reason.Scripts/unit-tests.shfails on an unlisted skip. A Mac without Bun gets a named failure where the stub-server tests used to go quiet.build.ymlgained a step, so the unit job's compiler cache rebuilds once.MCP_REGISTRY_PUBLISH=falseturns it off). v0.12.2 is still missing from the registry.META_API_KEYsecret's only user are removed.HackathonFilmUITestsstays in the UI suite.