Skip to content

Windows distribution: CLI version metadata, SignPath CI, PATH/ALLUSERS installer, Scoop, and Winget consolidation - #541

Merged
stevyhacker merged 1 commit into
masterfrom
windows-distribution-upgrades
Nov 19, 2026
Merged

stevyhacker merged 1 commit into
masterfrom
windows-distribution-upgrades

Conversation

@stevyhacker

Copy link
Copy Markdown
Owner

Summary

Prepares LokalBot's Windows distribution stack so code signing, enterprise rollouts, and package managers work cleanly with minimal friction:

  • SignPath Foundation readiness: Embeds Windows VERSIONINFO metadata (ProductName = LokalBot, matching workspace ProductVersion) into lokalbot-cli.exe via LinuxWindows/crates/lokalbot-cli/build.rs (matching lokalbot.exe and setup.exe), adds SignPath XML artifact configs (windows-binaries.xml, windows-installer.xml), adds opt-in .github/workflows/windows-sign.yml wired into release.yml behind vars.SIGNPATH_ENABLED == 'true', and documents the setup in Docs/releasing/windows-signing.md.
  • Installer UX & enterprise support (lokalbot.iss): Adds an on-by-default task to install lokalbot-cli.exe into {app}\bin and manage user/system PATH cleanly on install and uninstall (ChangesEnvironment=yes), and adds PrivilegesRequiredOverridesAllowed=commandline with {autopf} / HKA so default installs stay zero-UAC per-user while IT admins can deploy machine-wide with /ALLUSERS /VERYSILENT. Updates check-windows-installer.ps1 to verify PATH addition and cleanup.
  • Scoop support: Teaches lokalbot-update to recognize Scoop-managed installations as Placement::Managed (unit-tested) and documents the live stevyhacker/scoop-bucket install command in README.md and LinuxWindows/README.md.
  • Winget consolidation: Removes the duplicate Distribution/winget/ manifests (LokalBot.LokalBot) that conflicted with the canonical stevyhacker.LokalBot setup (already open as microsoft/winget-pkgs#457268) and updates LinuxWindows/packaging/winget/manifests/s/stevyhacker/LokalBot/ to 0.13.2.

Validation

# From LinuxWindows/
TMPDIR=/tmp cargo test -p lokalbot-update -p lokalbot-cli
# lokalbot-cli: 50 unit + 18 integration passed; lokalbot-update: 45 passed; lokalbot-update-feed: 2 passed
cargo fmt --check
cargo clippy -p lokalbot-cli -p lokalbot-update --all-targets -- -D warnings

# From repo root
python3 -m unittest discover -s Scripts/tests -v             # 227 passed
python3 Scripts/release/release-preflight.py --metadata-only # Release metadata valid: 0.13.2 (68)
python3 Website/generator/render_web.py --check              # All 43 generated web files up to date
LinuxWindows/scripts/third-party-licenses.sh --check         # LICENSES/rust-crates.md is up to date

Windows Inno Setup compilation, check-windows-installer.ps1, and winget validate / silent install-uninstall will run on hosted windows-2025 CI runners via linux-windows-release.yml and winget.yml on this PR. SignPath end-to-end signing remains opt-in (SIGNPATH_ENABLED=true) until SignPath Foundation approves the application.

Changed test expectations

None.

Linked issues

None.

Risk / rollout notes

  • windows-sign in release.yml is strictly gated on vars.SIGNPATH_ENABLED == 'true'; until enabled, linux-windows-publish falls back to release-windows-x86_64 with zero behavior change.
  • Default installer behavior stays per-user (PrivilegesRequired=lowest) under %LOCALAPPDATA%\Programs\LokalBot, preserving compatibility with Winget Scope: user and in-place updates.

…S installer, Scoop, and Winget consolidation
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
lokalbot 2c2c357 Commit Preview URL

Branch Preview URL
Nov 19 2026, 10:10 AM

@stevyhacker
stevyhacker marked this pull request as ready for review November 19, 2026 10:32
@stevyhacker
stevyhacker merged commit 1237a09 into master Nov 19, 2026
34 checks passed
@stevyhacker stevyhacker mentioned this pull request Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant