Skip to content

SignPath: add test-signing workflow_dispatch, product-name rules, and code signing policy - #555

Merged
stevyhacker merged 1 commit into
masterfrom
signpath-test-signing-and-policy
Nov 20, 2026
Merged

stevyhacker merged 1 commit into
masterfrom
signpath-test-signing-and-policy

Conversation

@stevyhacker

Copy link
Copy Markdown
Owner

Summary

  • Add workflow_dispatch test-signing support to .github/workflows/windows-sign.yml (defaulting to test-signing policy with a secret-free Windows source build job and self-signed test certificate verification) so SignPath Foundation's onboarding test run can be executed without cutting a release tag.
  • Bump SignPath/github-action-submit-signing-request to v3.2, add actions: read permission in windows-sign.yml and release.yml, and enforce product-name="LokalBot" in windows-binaries.xml and windows-installer.xml.
  • Publish the required SignPath Foundation Code signing policy in README.md (and align SECURITY.md and Docs/releasing/windows-signing.md with SignPath's onboarding sequence).

Validation

python3 -c 'import yaml; [yaml.safe_load(open(p)) for p in [".github/workflows/windows-sign.yml", ".github/workflows/release.yml"]]'
# YAML OK

xmllint --noout LinuxWindows/packaging/windows/signpath/windows-binaries.xml LinuxWindows/packaging/windows/signpath/windows-installer.xml
# XML OK

python3 -m unittest discover -s Scripts/tests -v
# Ran 245 tests in 33.751s — OK

Changed test expectations

None.

Linked issues

None.

@stevyhacker
stevyhacker marked this pull request as ready for review November 20, 2026 13:38
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
lokalbot 314aea5 Commit Preview URL

Branch Preview URL
Nov 20 2026, 01:38 PM

@stevyhacker
stevyhacker merged commit f0ce5e2 into master Nov 20, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant