Skip to content

SignPath: remove product-name check from Inno Setup windows-installer.xml - #558

Merged
stevyhacker merged 1 commit into
masterfrom
signpath-installer-xml-sync
Nov 21, 2026
Merged

stevyhacker merged 1 commit into
masterfrom
signpath-installer-xml-sync

Conversation

@stevyhacker

Copy link
Copy Markdown
Owner

Summary

  • Remove product-name="LokalBot" from LinuxWindows/packaging/windows/signpath/windows-installer.xml (and document why in Docs/releasing/windows-signing.md) to match the updated windows-installer configuration in SignPath. Inno Setup 6 pads VersionInfoProductName in its precompiled setup stub with trailing spaces, which failed SignPath's exact product-name string check on signing request 66959946-8293-454b-94b5-723bf526f420. windows-binaries.xml still strictly enforces product-name="LokalBot" on lokalbot.exe and lokalbot-cli.exe.

Validation

xmllint --noout LinuxWindows/packaging/windows/signpath/windows-installer.xml
# exit 0

Verified live against SignPath test-signing rerun on run 44749247511.

Changed test expectations

None.

Linked issues

None.

@stevyhacker
stevyhacker marked this pull request as ready for review November 20, 2026 15:14
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
lokalbot cd68ad8 Commit Preview URL

Branch Preview URL
Nov 20 2026, 03:15 PM

@stevyhacker
stevyhacker merged commit 26c9e8e into master Nov 21, 2026
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant