Repository navigation
SignPath: remove product-name check from Inno Setup windows-installer.xml - #558
Merged
Merged
Conversation
stevyhacker
marked this pull request as ready for review
November 20, 2026 15:14
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lokalbot | cd68ad8 | Commit Preview URL Branch Preview URL |
Nov 20 2026, 03:15 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
product-name="LokalBot"fromLinuxWindows/packaging/windows/signpath/windows-installer.xml(and document why inDocs/releasing/windows-signing.md) to match the updatedwindows-installerconfiguration in SignPath. Inno Setup 6 padsVersionInfoProductNamein its precompiled setup stub with trailing spaces, which failed SignPath's exactproduct-namestring check on signing request66959946-8293-454b-94b5-723bf526f420.windows-binaries.xmlstill strictly enforcesproduct-name="LokalBot"onlokalbot.exeandlokalbot-cli.exe.Validation
xmllint --noout LinuxWindows/packaging/windows/signpath/windows-installer.xml # exit 0Verified live against SignPath
test-signingrerun on run 44749247511.Changed test expectations
None.
Linked issues
None.