Repository navigation
Conversation
…l-detection # Conflicts: # LokalBot/Resources/ar-EG.lproj/Localizable.strings # LokalBot/Resources/ar.lproj/Localizable.strings # LokalBot/Resources/bn.lproj/Localizable.strings # LokalBot/Resources/de.lproj/Localizable.strings # LokalBot/Resources/en.lproj/Localizable.strings # LokalBot/Resources/es.lproj/Localizable.strings # LokalBot/Resources/fr.lproj/Localizable.strings # LokalBot/Resources/ha.lproj/Localizable.strings # LokalBot/Resources/hi.lproj/Localizable.strings # LokalBot/Resources/id.lproj/Localizable.strings # LokalBot/Resources/it.lproj/Localizable.strings # LokalBot/Resources/ja.lproj/Localizable.strings # LokalBot/Resources/ko.lproj/Localizable.strings # LokalBot/Resources/mr.lproj/Localizable.strings # LokalBot/Resources/pcm.lproj/Localizable.strings # LokalBot/Resources/pt.lproj/Localizable.strings # LokalBot/Resources/ru.lproj/Localizable.strings # LokalBot/Resources/sr-Latn.lproj/Localizable.strings # LokalBot/Resources/sw.lproj/Localizable.strings # LokalBot/Resources/te.lproj/Localizable.strings # LokalBot/Resources/ur.lproj/Localizable.strings # LokalBot/Resources/vi.lproj/Localizable.strings # LokalBot/Resources/zh-Hans.lproj/Localizable.strings # LokalBot/Resources/zh-Hant.lproj/Localizable.strings # LokalBot/Services/Recording/MeetingDetector.swift # LokalBot/Services/Recording/RecordingController.swift # LokalBotTests/Models/Meetings/MeetingIntegrityTests.swift # PRIVACY.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add eXpress and user-selected native call apps on macOS and Windows, plus an opt-in microphone-based detector for other browser meeting sites. Settings uses a native
.app/.exepicker and removable named rows; users do not need to enter bundle IDs or process names.Built on current master, including the maintainer's follow-ups to merged #511/#513. This does not re-propose those merged changes. Microphone-based native sessions use their own stop grace even when a calendar event is present; Windows confirmation/handoff uses executable identity rather than a potentially shared display name. Browser window eligibility is recorded/replayed as a boolean through CaptureEnvironment. Windows process-loopback activation also keeps its
PROPVARIANTfrom freeing a borrowed stack blob: live eXpress validation exposed a native fail-fast at recording start, reproduced independently of the call detector and GUI.Validation
cargo test -p lokalbot-core -p lokalbot-platform -p lokalbot-i18n --lib --locked --jobs 3 --no-fail-fast: 538 + 230 + 14 passed, 0 failed, 1 ignored.ManuallyDropreproduces 0xc0000409 without an audio device; with the fix, 54 audio tests passed, 0 failed, 0 ignored. A separateSession::open(current PID)probe reproduces the native fail-fast before the fix and passes afterward, independently of eXpress and GPUI. The combined Windows Dev app rebuilt successfully after the fix in 56.76s.Finished dev profilein 3m 46s). Repeated the actual GUI flow: selected Telegram in the native file dialog, saw the extracted nameTelegram Desktop, quit with Ctrl+Q, relaunched and confirmed the saved row, then removed it with the trash icon. No identifier was typed.Still required before Ready:
GitHub Actions currently reports
action_requiredfor all five workflows: maintainer authorization is required to run workflows from this fork. No upstream CI pass is claimed.Changed test expectations
CaptureTraceScrubberTests/testEveryDetectionBundleIDSurvivesScrubbingnow also enumeratesmicrophoneBrowsers. The invariant is unchanged: every built-in detection bundle ID must survive scrubbing so replay retains detector identity. The new detector uses additional built-in browser IDs that the old enumeration omitted. No existing success/failure assertion was weakened.Linked issues
Follow-up to merged #511 and #513.
Risk / rollout notes
Draft: not ready for merge. Browser microphone detection is off by default and its UI explains that other tabs' audio in the same browser can be captured. Native selections are explicit and removable. Unknown/private browser windows fail closed. Existing string-format custom-app settings migrate to named records; this is a settings-schema change and downgrading may require removing the new setting first. No destructive data migration is performed.
Recording ownership, end-of-call timing and audio recovery are the main regression surface. macOS local ad-hoc rebuilds can require renewed TCC permission; signed distribution and real-call validation remain required. Linux behavior is not claimed as tested by this PR. No production release is included.