Skip to content

feat(meetings): detect eXpress and user-selected call apps - #565

Draft
region23 wants to merge 6 commits into
stevyhacker:masterfrom
region23:codex/corporate-call-detection
Draft

region23 wants to merge 6 commits into
stevyhacker:masterfrom
region23:codex/corporate-call-detection

Conversation

@region23

@region23 region23 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add eXpress and user-selected native call apps on macOS and Windows, plus an opt-in microphone-based detector for other browser meeting sites. Settings uses a native .app/.exe picker and removable named rows; users do not need to enter bundle IDs or process names.

Settings → Meetings → Choose application → app name → trash to remove
sustained microphone use → confirmed source → recording
late call-audio helper → attach to the existing recording

Built on current master, including the maintainer's follow-ups to merged #511/#513. This does not re-propose those merged changes. Microphone-based native sessions use their own stop grace even when a calendar event is present; Windows confirmation/handoff uses executable identity rather than a potentially shared display name. Browser window eligibility is recorded/replayed as a boolean through CaptureEnvironment. Windows process-loopback activation also keeps its PROPVARIANT from freeing a borrowed stack blob: live eXpress validation exposed a native fail-fast at recording start, reproduced independently of the call detector and GUI.

Validation

  • macOS ARM64: signed unit-test build, 177 passed, 0 failed, 2 approved skips across settings, detector, ownership, recovery, capture replay and scrubbing suites. The two skips require an optional real-browser trace/private replay fixture; the skip-policy check passed.
  • Red/green: late-output-helper regressions fail before the callback fix and pass afterward; private/unreadable browser-window replay fails without the recorded permission fact and passes with it. Windows calendar-grace and same-display-name/different-executable regressions pass.
  • Native Windows 11 ARM64 in UTM: verified the transferred source hashes; cargo test -p lokalbot-core -p lokalbot-platform -p lokalbot-i18n --lib --locked --jobs 3 --no-fail-fast: 538 + 230 + 14 passed, 0 failed, 1 ignored.
  • Native Windows audio regression: temporarily removing the outer ManuallyDrop reproduces 0xc0000409 without an audio device; with the fix, 54 audio tests passed, 0 failed, 0 ignored. A separate Session::open(current PID) probe reproduces the native fail-fast before the fix and passes afterward, independently of eXpress and GPUI. The combined Windows Dev app rebuilt successfully after the fix in 56.76s.
  • macOS Dev build succeeded. Manually selected Telegram using the native picker, verified persistence after quit/relaunch, and removed it with the trash button. No application identifier was typed.
  • Windows ARM64 Dev app build succeeded (Finished dev profile in 3m 46s). Repeated the actual GUI flow: selected Telegram in the native file dialog, saw the extracted name Telegram Desktop, quit with Ctrl+Q, relaunched and confirmed the saved row, then removed it with the trash icon. No identifier was typed.
  • Live native eXpress on Windows ARM64 after the fix: automatic recording start/stop, saved mic and process-loopback system tracks, and the same app process surviving the call. The saved recording is 5m53s; a synthetic control phrase was recognized twice from the system track alone with the existing local Whisper server. Capture health reports 0 dropped mic buffers and 0 dropped system buffers. The Windows GUI shows the finalized recording and Record button. STT/Think processing inside the Windows app remains unconfigured; this is an audio-capture check.
  • Live eXpress in the existing Chrome profile on Windows ARM64, with browser detection opted in: automatic start/stop saved a 2m26s recording with both tracks, and a distinct synthetic control phrase was recognized from the system track alone. The same app process survived; capture health reports 0 dropped mic buffers and 0 dropped system buffers. The finalized GUI identifies it as Browser call, rather than resolving the site name. The log shows the existing whole-output fallback about five seconds before recording ended; uninterrupted browser-only audio isolation is not established by this test. STT/Think inside the Windows app remains unconfigured; the voice check used the existing local Mac Whisper server.
  • SwiftLint strict, Cargo formatting, localization sync, capture-recording policy and 9 localization-script tests passed. Mac-host Rust meeting tests: 44 passed.
  • Broader Rust checks on the Mac also expose existing locale assumptions in two i18n tests and unsupported Windows/Linux platform tests; those runs are not reported as fully green.

Still required before Ready:

  • Native Windows ARM64 app build and picker → full restart → trash in the actual GUI.
  • One live native eXpress call on Windows ARM64: automatic start/stop and separate verified remote-speaker system track after the process-loopback fix.
  • One live eXpress call in Chrome on Windows ARM64: automatic start/stop and verified remote-speaker system track through the opt-in browser detector.
  • Browser/native calls on macOS; muted/rejoined calls and output-device changes. Review the observed end-of-call whole-output fallback; this browser run does not prove uninterrupted source isolation.
  • Recheck existing Telemost/MTS Link browser/native flows and browser privacy boundaries with real calls.
  • Native Windows x64 and upstream CI validation; ARM64 VM checks do not establish x64 or physical-device audio behavior.

GitHub Actions currently reports action_required for all five workflows: maintainer authorization is required to run workflows from this fork. No upstream CI pass is claimed.

Changed test expectations

CaptureTraceScrubberTests/testEveryDetectionBundleIDSurvivesScrubbing now also enumerates microphoneBrowsers. The invariant is unchanged: every built-in detection bundle ID must survive scrubbing so replay retains detector identity. The new detector uses additional built-in browser IDs that the old enumeration omitted. No existing success/failure assertion was weakened.

Linked issues

Follow-up to merged #511 and #513.

Risk / rollout notes

Draft: not ready for merge. Browser microphone detection is off by default and its UI explains that other tabs' audio in the same browser can be captured. Native selections are explicit and removable. Unknown/private browser windows fail closed. Existing string-format custom-app settings migrate to named records; this is a settings-schema change and downgrading may require removing the new setting first. No destructive data migration is performed.

Recording ownership, end-of-call timing and audio recovery are the main regression surface. macOS local ad-hoc rebuilds can require renewed TCC permission; signed distribution and real-call validation remain required. Linux behavior is not claimed as tested by this PR. No production release is included.

region23 and others added 6 commits November 17, 2026 14:52
…l-detection

# Conflicts:
#	LokalBot/Resources/ar-EG.lproj/Localizable.strings
#	LokalBot/Resources/ar.lproj/Localizable.strings
#	LokalBot/Resources/bn.lproj/Localizable.strings
#	LokalBot/Resources/de.lproj/Localizable.strings
#	LokalBot/Resources/en.lproj/Localizable.strings
#	LokalBot/Resources/es.lproj/Localizable.strings
#	LokalBot/Resources/fr.lproj/Localizable.strings
#	LokalBot/Resources/ha.lproj/Localizable.strings
#	LokalBot/Resources/hi.lproj/Localizable.strings
#	LokalBot/Resources/id.lproj/Localizable.strings
#	LokalBot/Resources/it.lproj/Localizable.strings
#	LokalBot/Resources/ja.lproj/Localizable.strings
#	LokalBot/Resources/ko.lproj/Localizable.strings
#	LokalBot/Resources/mr.lproj/Localizable.strings
#	LokalBot/Resources/pcm.lproj/Localizable.strings
#	LokalBot/Resources/pt.lproj/Localizable.strings
#	LokalBot/Resources/ru.lproj/Localizable.strings
#	LokalBot/Resources/sr-Latn.lproj/Localizable.strings
#	LokalBot/Resources/sw.lproj/Localizable.strings
#	LokalBot/Resources/te.lproj/Localizable.strings
#	LokalBot/Resources/ur.lproj/Localizable.strings
#	LokalBot/Resources/vi.lproj/Localizable.strings
#	LokalBot/Resources/zh-Hans.lproj/Localizable.strings
#	LokalBot/Resources/zh-Hant.lproj/Localizable.strings
#	LokalBot/Services/Recording/MeetingDetector.swift
#	LokalBot/Services/Recording/RecordingController.swift
#	LokalBotTests/Models/Meetings/MeetingIntegrityTests.swift
#	PRIVACY.md

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant