Skip to content

fix(digest): honor note language in daily reports - #566

Draft
region23 wants to merge 1 commit into
stevyhacker:masterfrom
region23:codex/day-summary-language
Draft

region23 wants to merge 1 commit into
stevyhacker:masterfrom
region23:codex/day-summary-language

Conversation

@region23

@region23 region23 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Make Yesterday/daily reports and day digests honor the configured note language on macOS and Windows/Linux. For example, Russian notes with an English interface now request Russian prose on every generation pass, including truncation retries and post-model session additions.

explicit note language → daily generation language
Match Transcript / empty → resolved interface language
generation language → prompts + retries + digest cache key + fallback labels

Daily evidence has no single transcript, so the interface language supplies the fallback for Match Transcript. JSON keys, status values, source IDs, parser-required headings and quoted evidence retain their canonical form. Saved reports and original evidence are not rewritten.

Validation

  • macOS ARM64 signed unit-test build: 143 passed, 0 failed, 0 skipped across Dreaming, DreamLoop, DayDigestEvidence, DayDigestLifecycle and CodingAgentDigestModel suites; skip-policy check passed.
  • Red/green: disabling the output-language directive reproduces failures in testDreamRequestsKeepRussianAfterOutputLimitAndParseTheReply and testDigestLanguageReachesEveryPassAndRetryAndSeparatesCachedLanguages; restoring it passes both. Tests inspect all passes and retries and exercise parsed responses/cache separation.
  • Rust on macOS ARM64, rebuilt from this commit: 34 passed, 0 failed, 0 ignored across language (3), dream (15) and digest (16), including localized post-model session augmentation.
  • Full Rust AI suite on this Mac: 562 passed, 1 failed, 3 ignored. The unchanged runtime::tests::healthy_cuda_helper_is_reclaimed_before_a_failed_probe fails with GPU is busy; an isolated copy of clean master dd49d90 reproduces the exact same failure. This is not presented as a fully green suite.
  • Native Windows 11 ARM64 UTM: 540 passed, 0 failed, 3 ignored for cargo test -p lokalbot-ai --lib --locked --jobs 3 --no-fail-fast. The app build also exited 0 (1m 08s). SHA verification covered all 872 source files for the combined corporate-call commit 25803918 plus this language commit 27d4e581 (six non-overlapping Rust files).
  • SwiftLint strict, cargo fmt --all -- --check and git diff --check passed.

Still required before Ready:

  • Native Windows ARM64 AI tests and app build.
  • Generate fresh synthetic Russian reports with a real local model through the GUI on both platforms; inspect all visible sections and fallback/retry behavior.
  • Upstream CI and additional supported-language smoke checks.

GitHub Actions currently reports action_required for all five workflows: maintainer authorization is required to run workflows from this fork. No upstream CI pass is claimed.

Changed test expectations

None. Three existing fake TextEngine implementations now recognize the original system-prompt prefix rather than requiring exact equality with the unadorned base prompt. The old routing silently selected the wrong fake response once the language directive was appended; all existing expected report contents/assertions are retained.

Linked issues

None.

Risk / rollout notes

Draft: not ready for merge. The change touches scheduled and explicit daily generation, digest caching and model-free fallbacks on both implementations. Canonical parser/schema tokens remain unchanged. A model can still ignore an instruction; the real-model smoke test is outstanding.

Custom note languages and languages without a UI catalog use the requested language for model-generated prose and the interface catalog for deterministic fallback labels. Proper names, quoted evidence and stored actions remain verbatim. Existing English reports require explicit regeneration. Rollback is code-only; no saved report or library migration is performed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant