Skip to content

Meeting player: waveform zoom/pan, 2-click range selection, trim & extract to new meeting - #574

Open
blx10 wants to merge 4 commits into
stevyhacker:masterfrom
blx10:feat/meeting-waveform-selection
Open

blx10 wants to merge 4 commits into
stevyhacker:masterfrom
blx10:feat/meeting-waveform-selection

Conversation

@blx10

@blx10 blx10 commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Makes long manual recordings that ran past a call or captured back-to-back meetings easy to inspect, narrow, and split directly from the meeting player bar, while keeping transcript navigation one click away on every tab:

  • 1.5x waveform & clickable caption row: Enlarges WaveformView in MeetingPlayerBar (60pt / 36pt with caption) and replaces the separate "Show in transcript" button (which hid on the Transcript tab) with a clickable captionRow (meeting.player.caption) available across Summary, Transcript, and Notes.
  • Cursor-anchored zoom & horizontal pan: Adds 1x–30x mouse-wheel and trackpad pinch zoom anchored at the cursor timestamp (WaveformViewport), horizontal panning (Shift+wheel, trackpad horizontal scroll, and a 3pt bottom scrollbar), an Nx reset pill, and high-resolution (detailBinCount = 16_384) slice resampling in WaveformAnalysis.
  • 2-click yellow range selection & Trim to Selection: First click seeks and marks start, second click seeks and highlights the yellow range in either direction, third click restarts selection, and Esc/✕ clears (WaveformSelectionState). Trim to Selection narrows contentRange non-destructively (keeping raw audio on disk and scoping MeetingPlayer + WaveformView playback to [windowStart, windowEnd], reversible via "Use full recording").
  • New Meeting from Selection: Creates a standalone <Title> (MM:SS–MM:SS) meeting (MeetingSelectionExtractService + AppState.extractMeeting) without modifying the source recording—slicing mic.m4a/system.m4a, copying and zero-shifting overlapping transcript.json/transcript.md segments (retaining speaker aliases), copying notes.md, linking screen context via Meeting.extractedFromMeetingID, switching to the new meeting, and queuing transcription + summarization.

Atomic Commit Plan

Implemented across 4 self-contained commits on top of upstream/master:

  1. cb25dfe7 — feat(ui): enlarge meeting waveform 1.5x and make player caption jump to transcript
  2. e5bdaaae — feat(ui): add cursor-anchored zoom and horizontal pan to meeting waveform
  3. b7319795 — feat(meetings): add 2-click yellow waveform selection and Trim to Selection
  4. e158f208 — feat(meetings): add New Meeting from Selection with sliced tracks and context

Validation

python3 -m unittest Scripts/tests/test_localization.py
# Ran 6 tests in 3.034s — OK

python3 Scripts/ci/comment-ratchet.py --check
# Comment lines: 0 (baseline 0).

swiftlint lint --strict --quiet
# exit 0

xcodegen generate
xcodebuild test -project LokalBot.xcodeproj -scheme LokalBot \
  -configuration Debug -destination 'platform=macOS,arch=arm64' \
  CODE_SIGNING_ALLOWED=NO \
  -only-testing:LokalBotTests/WaveformAnalysisTests \
  -only-testing:LokalBotTests/MeetingAudioAssetTests \
  -only-testing:LokalBotTests/MeetingAudioRecoveryTests \
  -only-testing:LokalBotTests/MeetingSelectionExtractServiceTests \
  -only-testing:LokalBotTests/MeetingScreenContextTests \
  -only-testing:LokalBotTests/MeetingTests
# ** TEST SUCCEEDED **  Executed 53 tests (MeetingAudioAssetTests: 18, MeetingAudioRecoveryTests: 7, MeetingScreenContextTests: 8, MeetingSelectionExtractServiceTests: 1, MeetingTests: 6, WaveformAnalysisTests: 13), with 0 failures (0 unexpected)

Local manual verification performed on macOS against the user's library; LokalBotUITests were not run locally per AGENTS.md (delegated to hosted CI once marked ready for review).

Changed test expectations

  • RedesignUITests/testMeetingWorkspaceKeepsOutcomesReadableWhileRefreshing: app.buttons["meeting.player.showInTranscript"].click() → app.buttons["meeting.player.caption"].click()
    • Why the old expectation was wrong: "Show in transcript" was hidden whenever the Transcript tab was active (tab != .transcript), preventing subsequent clicks from jumping back to the playhead line after scrolling or seeking; making the player caption row (meeting.player.caption) itself the jump button keeps transcript navigation available across all tabs.

Linked issues

None

Risk / rollout notes

  • "Trim to Selection" preserves raw audio files on disk (contentRange / userReviewed); "Use full recording" in the waveform context menu (or MeetingBoundaryEditor) restores full playback and waveform bounds.
  • Meeting.extractedFromMeetingID links ActivityStore.screenshots for extracted meetings without duplicating screenshot rows.
  • Updated all 24 Localizable.strings catalogs for "Clear Selection", "Trim to Selection", and "New Meeting from Selection".
  • Installs a local NSEvent [.scrollWheel, .magnify] monitor only while hovering over WaveformView, and removes it on hover exit and .onDisappear.

@blx10
blx10 marked this pull request as ready for review November 21, 2026 22:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant