Repository navigation
Keep upgrade fixtures and seed names Windows-safe - #575
Open
SamLeatherdale wants to merge 3 commits into
Open
SamLeatherdale wants to merge 3 commits into
SamLeatherdale wants to merge 3 commits into
Conversation
Upgrade fixtures for 0.6.2 through 0.13.2 named meeting folders like 27-1:1-with-maya. Windows does not allow a colon in a file name, so Git for Windows could not check out the repository. The colon came from Scripts/test/seed_demo_library.py, which built folder names from the raw title. The app's own slug already turns it into a dash. - Rename the 350 files in 70 meeting folders from 1:1-with-maya to 1-1-with-maya, and set relativePath in each meta.json to match. Titles, ids and all other bytes are unchanged. - The seed replaces characters Windows rejects with dashes, so future fixtures stay portable. - Add Scripts/ci/check-path-portability.py and run it in the Lint workflow, so a tracked path Windows cannot check out fails the pull request. Changed test expectations: none. New tests are in Scripts/tests/test_check_path_portability.py and DemoLibraryFolderNameTests in Scripts/tests/test_seed_demo_library.py. Co-authored-by: Cursor <cursoragent@cursor.com>
The Windows path check runs as one step in the existing CI helpers job on the same Linux VM as the unit tests, instead of a separate lint job. The check's unit test already ran there, so the separate job only added a second runner. Co-authored-by: Cursor <cursoragent@cursor.com>
The path check's unit test already runs in the same job through unittest discover, so the extra command repeated the same check. Co-authored-by: Cursor <cursoragent@cursor.com>
SamLeatherdale
marked this pull request as ready for review
November 22, 2026 01:29
Owner
|
Thanks for your contributions, will review now! |
stevyhacker
approved these changes
Nov 22, 2026
stevyhacker
left a comment
Owner
There was a problem hiding this comment.
Thanks, this looks good: renames, seed fix and the path check all line up, and nothing in the fixtures still points at the old names.
Generated by Claude Code
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream fixtures and the demo seed used names with
:(for example27-1:1-with-maya). Windows can't create those names, so a Windows clone fails at checkout. This renames the 350 fixture paths to27-1-1-with-maya, makes the demo seed write Windows-safe folder names, and adds a check plus tests so bad names fail in CI.Validation
python3 Scripts/ci/check-path-portability.pyonupstream/master(d92e140): 350 failing paths, as expected. On this branch: all 8965 tracked paths pass.python3 -m unittest discover -s Scripts/testson Linux (Ubuntu under WSL, Python 3.14): 273 tests, OK, 7 skipped (macOS-only).Changed test expectations
None. A grep outside
LokalBotTests/Fixtures/finds no test that asserts on the old folder names. The new tests intest_seed_demo_library.pyandtest_check_path_portability.pycover the new names.Linked issues
None.
Risk / rollout notes
meta.jsonfiles have a newrelativePath(...DD-1-1-with-maya), and 350 fixture paths were renamed. Upgrade tests on macOS and Rust fixture tests are the ones to watch in CI.Benchmarks/autocomplete/**/source-*.jsonstill record the old names. They are historical records and no script reads them..github/workflows/upgrade-fixtures.ymlabout colon names, and the Windows git-archive workaround in.github/workflows/linux-windows.yml.ci-helpers.yml), through its unit test.