Skip to content

Keep upgrade fixtures and seed names Windows-safe - #575

Open
SamLeatherdale wants to merge 3 commits into
stevyhacker:masterfrom
SamLeatherdale:fix/windows-safe-fixture-paths
Open

SamLeatherdale wants to merge 3 commits into
stevyhacker:masterfrom
SamLeatherdale:fix/windows-safe-fixture-paths

Conversation

@SamLeatherdale

Copy link
Copy Markdown
Contributor

Summary

Upstream fixtures and the demo seed used names with : (for example 27-1:1-with-maya). Windows can't create those names, so a Windows clone fails at checkout. This renames the 350 fixture paths to 27-1-1-with-maya, makes the demo seed write Windows-safe folder names, and adds a check plus tests so bad names fail in CI.

Validation

  • python3 Scripts/ci/check-path-portability.py on upstream/master (d92e140): 350 failing paths, as expected. On this branch: all 8965 tracked paths pass.
  • python3 -m unittest discover -s Scripts/tests on Linux (Ubuntu under WSL, Python 3.14): 273 tests, OK, 7 skipped (macOS-only).
  • Path check unit tests: 6 pass. The seed test was checked by reverting the seed fix locally, which reproduces WinError 267 on Windows.
  • Not run here: the Swift and Rust tests that read the upgrade fixtures. Those run in hosted CI. I did not run any UI tests locally.

Changed test expectations

None. A grep outside LokalBotTests/Fixtures/ finds no test that asserts on the old folder names. The new tests in test_seed_demo_library.py and test_check_path_portability.py cover the new names.

Linked issues

None.

Risk / rollout notes

  • Fixture data changed: 70 meta.json files have a new relativePath (...DD-1-1-with-maya), and 350 fixture paths were renamed. Upgrade tests on macOS and Rust fixture tests are the ones to watch in CI.
  • Benchmarks/autocomplete/**/source-*.json still record the old names. They are historical records and no script reads them.
  • Left for a follow-up: a stale comment in .github/workflows/upgrade-fixtures.yml about colon names, and the Windows git-archive workaround in .github/workflows/linux-windows.yml.
  • The path check runs as a step in the CI helpers job (ci-helpers.yml), through its unit test.

SamLeatherdale and others added 3 commits November 22, 2026 12:12
Upgrade fixtures for 0.6.2 through 0.13.2 named meeting folders like
27-1:1-with-maya. Windows does not allow a colon in a file name, so Git for
Windows could not check out the repository. The colon came from
Scripts/test/seed_demo_library.py, which built folder names from the raw
title. The app's own slug already turns it into a dash.

- Rename the 350 files in 70 meeting folders from 1:1-with-maya to
  1-1-with-maya, and set relativePath in each meta.json to match. Titles,
  ids and all other bytes are unchanged.
- The seed replaces characters Windows rejects with dashes, so future
  fixtures stay portable.
- Add Scripts/ci/check-path-portability.py and run it in the Lint workflow,
  so a tracked path Windows cannot check out fails the pull request.

Changed test expectations: none. New tests are in
Scripts/tests/test_check_path_portability.py and
DemoLibraryFolderNameTests in Scripts/tests/test_seed_demo_library.py.

Co-authored-by: Cursor <cursoragent@cursor.com>
The Windows path check runs as one step in the existing CI helpers job on the
same Linux VM as the unit tests, instead of a separate lint job. The check's
unit test already ran there, so the separate job only added a second runner.

Co-authored-by: Cursor <cursoragent@cursor.com>
The path check's unit test already runs in the same job through unittest discover, so the extra command repeated the same check.

Co-authored-by: Cursor <cursoragent@cursor.com>
@SamLeatherdale
SamLeatherdale marked this pull request as ready for review November 22, 2026 01:29
@stevyhacker

Copy link
Copy Markdown
Owner

Thanks for your contributions, will review now!

@stevyhacker stevyhacker left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good: renames, seed fix and the path check all line up, and nothing in the fixtures still points at the old names.


Generated by Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants