Skip to content

fix problems with initial loading by pushing image to 2nd frame #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacob-tucker wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix problems with initial loading by pushing image to 2nd frame #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
753d5f3
test load times
jacob-tucker Feb 20, 2024
a15ce89
remove page as well
jacob-tucker Feb 20, 2024
929c9ff
bring the call back
jacob-tucker Feb 20, 2024
4c4acb4
add cast page back
jacob-tucker Feb 20, 2024
bac4b1b
back to nroaml frame w/ no image
jacob-tucker Feb 20, 2024
470d613
add placeholder for image
jacob-tucker Feb 20, 2024
19d4db2
see if this version works
jacob-tucker Feb 20, 2024
186107d
Merge pull request #9 from storyprotocol/main
jacob-tucker Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/cast/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export default async function Home({ params, searchParams, children }: any) {
{/* <FrameImage src={data.publicUrl} /> */}
<FrameImage>
<RootFrame imageSrc={castImage} castInfo={cast} type='start' />
{/* <TestFrame castId={params.id} castImage={castImage} /> */}
{/* <TestFrame castId={params.id} /> */}
{/* <div style={{ display: 'flex' }}>Hello there test. Cast #{params.id}</div> */}
</FrameImage>
<FrameButton>Join</FrameButton>
Expand Down Expand Up @@ -163,7 +163,6 @@ export default async function Home({ params, searchParams, children }: any) {
newCastInfo.prompt_input,
newCastInfo.layer_1_cast_id
);
//@ts
let pastPrompts: string[] = cast.version_history.map(ele => ele.prompt_input as string).filter(ele => !!ele).concat(state.inputText);
handleGenerateImage(cast.name, pastPrompts, createdArtcastId as number, farcaster_name);
state.currentCastId = createdArtcastId as number;
Expand Down
6 changes: 5 additions & 1 deletion lib/components/frames/RootFrame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ export default function RootFrame({ castInfo, imageSrc, type }: { castInfo: Cast
display: 'flex',
gap: '20px'
}}>
<img src={imageSrc} width="325px" />
{type != 'start' ? <img src={imageSrc} width="325px" />
: <div style={{ display: 'flex', flexDirection: 'column', justifyContent: 'center', alignItems: 'center', width: '325px', height: '325px', border: '2px solid black' }}>
<span>Click 'Join' to</span>
<span>see the image!</span>
</div>}
<div style={{
display: 'flex',
flexDirection: 'column',
Expand Down
4 changes: 2 additions & 2 deletions lib/components/frames/TestFrame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Cast } from "@/lib/types/cast.interface";

// @ts-nocheck
export default function TestFrame({ castId, castImage }: { castId: number, castImage: string }) {
export default function TestFrame({ castId }: { castId: number }) {
return (
<div
style={{
Expand Down Expand Up @@ -125,7 +125,7 @@ export default function TestFrame({ castId, castImage }: { castId: number, castI
display: 'flex',
gap: '20px'
}}>
<img src={castImage} width="325px" />
{/* <img src={castImage} width="325px" /> */}
<div style={{
display: 'flex',
flexDirection: 'column',
Expand Down