aes 0.9 support#49
Open
AlexTMjugador wants to merge 5 commits intostr4d:mainfrom
Open
Conversation
Without any escaping, the `<u8>` part in `Vec<u8>` is parsed as a HTML tag during documentation generation, which leads to invalid HTML.
This is required to support aes 0.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aes0.9 was recently released, introducing breaking changes due to the adoption of thecipher0.5.1 traits. Compared to the traits used in thecipher0.4 version used byfpe, these new traits differ in both naming and method signatures, but offer equivalent functionality. But because this crate currently depends on the olderciphertraits, andaes0.9 implements only the new ones without any compatibility layer,fpedoes not work withaes0.9.This PR updates
fpeto use the newerciphertraits along with the relatedcbctraits, restoring compatibility withaes0.9. This change requires a MSRV bump due to the updatedcipherdependency, and it also drops compatibility with earlieraesversions. Users who need support for olderaesreleases can continue using a previous version offpe.I tried to do the update with the goal of preserving existing behavior as much as possible. In doing so, I followed the migration guidance outlined in the following PRs:
BlockCipher*/BlockMode*RustCrypto/traits#1482Cloneimpls RustCrypto/block-modes#91Additionally, this PR addresses several lints identified by newer versions of Clippy and
cargo docand general CI staleness.