Skip to content

Conversation

@sneurlax
Copy link

@sneurlax sneurlax commented Jul 9, 2025

Replaces the panic-prone assert_eq!(stanzas.len(), expected_stanzas) with proper handling that:

  1. Checks if the stanza count matches the expected count.
  2. If there's a mismatch, creates a recipient::Error::Internal with a descriptive message.
  3. Sends the error via the IPC channel using .send(&mut phase)?.
  4. Returns gracefully instead of crashing.

Closes #576

@str4d
Copy link
Owner

str4d commented Dec 7, 2025

NACK per #576 (comment) because I intentionally panic in the plugin helper code when MUST requirements are violated.

@str4d str4d closed this Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic on stanza-count mismatch

2 participants