Repository navigation
Document final disposition of the disabled TS interop tests - #38
Merged
Merged
Conversation
Owner decision: the ts-integration/ts-end-to-end/ts-multiple-messages tests stay disabled in this repository and will not be revived here. The streamr network TS packages have changed a lot since the 2024 pin the harness was built against, and the TS interop harness will be rewritten in a separate project. The disabled add_test blocks and the run-ts-* scripts are kept as reference for that rewrite. Comment-only + MODERNIZATION.md; no functional change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only closeout of the last parked workstream from the modernization.
The
ts-integration-test/ts-end-to-end-test/ts-multiple-messages-testtrio (disabled since PR #22) will not be revived in this repository: the streamr network TS packages have changed a lot since the 2024 pin the harness was built against, and the TS interop harness will be rewritten in a separate project.DISABLEDcomments in the two CMakeLists now state the decision and point at the memo, instead of promising an in-repo revival.add_testblocks, therun-ts-*scripts, and thenative-ts-integrationsubmodule are kept untouched as reference for the rewrite.For context (useful for the rewrite project): the harness's low-level subscriber uses
@streamr/trackerless-network/@streamr/dht/@streamr/utils, which are published on npm (currently 103.3.1), so the new harness can depend on published packages instead of building the network monorepo from source. All three tests run fully against a local--localsubscriber on 127.0.0.1:44211 — no external servers.🤖 Generated with Claude Code