fix: detect pointer cycles in copyExportedFields to prevent stack overflow#1922
Closed
tamish560 wants to merge 3 commits into
Closed
fix: detect pointer cycles in copyExportedFields to prevent stack overflow#1922tamish560 wants to merge 3 commits into
tamish560 wants to merge 3 commits into
Conversation
Author
|
Closing this as a duplicate of #1916 by @cyphercodes, which was opened 19 days earlier and addresses the same issue (#1915). Should have checked for existing PRs before opening this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
copyExportedFieldsnow tracks visited pointer addresses to detect and break pointer cycles, preventing stack overflow on recursive data structures.Why
EqualExportedValuesrecurses through a value's exported fields viacopyExportedFields. When the value contains a pointer cycle (a struct that directly or indirectly points back to itself), the function follows the cycle indefinitely and exhausts the goroutine stack, killing the entire test binary.Closes #1915
How
copyExportedFieldsWithVisitedwhich accepts amap[uintptr]boolof visited pointer addresses.reflect.Zeroof the pointer type is returned, breaking the cycle.copyExportedFieldscallscopyExportedFieldsWithVisitedwith a fresh map.The returned zero value for cyclic pointers means both
aandbin a cycle likea.Self = a/b.Self = bgetSelf = nilin their copies, so the comparison reports them as equal.Testing
Added
TestEqualExportedValuesRecursiveStructwhich constructs a self-referential struct and verifiesEqualExportedValuescompletes without stack overflow. All existing tests pass unchanged.