Skip to content

enhance maintainability #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SpatLyu merged 2 commits into from
Mar 21, 2026
Merged

enhance maintainability #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8abd095
prevent bugs when the right hand side is zero
SpatLyu Apr 16, 2026
811324f
remove unnecessary concatenation
SpatLyu Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/fuzzyoverlay.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
formulavars = formula_varname(formula, data)
y = data[, formulavars[[1]], drop = TRUE]
xs = data[, formulavars[[2]]]
xs = xs %>%

Check notice on line 33 in R/fuzzyoverlay.R

View check run for this annotation

codefactor.io / CodeFactor

R/fuzzyoverlay.R#L33 

Use the |> pipe operator instead of the %>% pipe operator. (pipe_consistency_linter)
dplyr::mutate(dplyr::across(dplyr::where(is.factor),
as.character)) %>%

Check notice on line 35 in R/fuzzyoverlay.R

View check run for this annotation

codefactor.io / CodeFactor

R/fuzzyoverlay.R#L35 

Use the |> pipe operator instead of the %>% pipe operator. (pipe_consistency_linter)
purrr::map2_dfc(colnames(xs),
\(.x,.y) paste(.y,.x,sep = "_"))
meanrisk = purrr::map(xs, \(.x) tapply(y,.x,mean))
Expand All @@ -41,8 +41,8 @@
xsfn = dplyr::mutate(xs, dplyr::across(dplyr::everything(),
\(.x) return(fuzzynum[.x])))
fuzzyindice = apply(xsfn, 1, fuzzyf)
fuzzyzone = xs %>%

Check notice on line 44 in R/fuzzyoverlay.R

View check run for this annotation

codefactor.io / CodeFactor

R/fuzzyoverlay.R#L44 

Use the |> pipe operator instead of the %>% pipe operator. (pipe_consistency_linter)
split(seq(nrow(xs))) %>%
split(seq_len(nrow(xs))) %>%

Check notice on line 45 in R/fuzzyoverlay.R

View check run for this annotation

codefactor.io / CodeFactor

R/fuzzyoverlay.R#L45 

Use the |> pipe operator instead of the %>% pipe operator. (pipe_consistency_linter)
purrr::map2_chr(fuzzyindice,
\(.tdf,.indice) .tdf[1,.indice,drop = TRUE])
return(fuzzyzone)
Expand Down
2 changes: 1 addition & 1 deletion R/vector_toolkits.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ normalize_vector = \(x,to_left = 0,to_right = 1){
#'
generate_subsets = \(set,empty = TRUE,self = TRUE) {
n = length(set)
subsets = list(c())
subsets = list()
for (i in seq(set)) {
subsets = c(subsets, utils::combn(set, i, simplify = FALSE))
}
Expand Down
Loading