fix token_endpoint_auth_method for public clients #2310
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When registering an OAuth client via dynamic client registration (
POST /oauth/clients/register), the request fails with a NULL constraint violation:This happens because:
token_endpoint_auth_methodcolumn with a NOT NULL constraint (added via a hosted-only migration)OAuthServerClientmodel doesn't have theTokenEndpointAuthMethodfieldregisterOAuthServerClientnever sets this field when creating a new clientWhat is the new behavior?
The
token_endpoint_auth_methodis now properly set during OAuth client registration:"none""client_secret_basic"Additional context
This fix is required for MCP (Model Context Protocol) authentication to work with Supabase Auth as the OAuth provider. MCP clients like Claude Code check the
/.well-known/oauth-authorization-serverendpoint and if"none"is listed intoken_endpoint_auth_methods_supported, they register as public clients withtoken_endpoint_auth_method=none.Changes
TokenEndpointAuthMethodfield toOAuthServerClientstructDetermineTokenEndpointAuthMethod()function to determine the auth method based on explicit value or client type defaultsregisterOAuthServerClientto setTokenEndpointAuthMethodwhen creating clientsoauthServerClientToResponse- now uses the stored value directlyDetermineTokenEndpointAuthMethod