Conversation
VladaHarbour
force-pushed
the
sd-2089_view-mode-link
branch
from
899f068 to
eb69f3e
Compare
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour clean approach, and the behavior test rewrite is a nice improvement.
one thing to fix: goToAnchor is called on an object that doesn't have it, so anchor links won't work in production. the test hides this.
also a question about whether skipping linkPopoverResolver in viewing mode is intentional. not blocking.
one small cleanup suggestion on the rel parsing. tests look good.
left inline comments.
VladaHarbour
force-pushed
the
sd-2089_view-mode-link
branch
from
eb69f3e to
d5cc8e6
Compare
|
Hi @caio-pizzol! Could you please check linkPopoverResolver related comment? Didn't add any fixes for this so far but everything else was addressed |
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour goToAnchor fix and rel cleanup look good. you're right about the resolver — direct navigation is the right call for viewing mode.
one thing: navigateToAnchor scrolls twice per click — left a suggestion. also a small cleanup on _presentationEditor.
packages/super-editor/src/components/link-click/LinkClickHandler.vue
Outdated
Show resolved
Hide resolved
3 participants
Open link in new tab in View mode instead of opening edit link modal.