feat: Add numberingFormat to orderedList (SD-1008)#2366
Draft
caio-pizzol wants to merge 8 commits intomainfrom
Draft
feat: Add numberingFormat to orderedList (SD-1008)#2366caio-pizzol wants to merge 8 commits intomainfrom
caio-pizzol wants to merge 8 commits intomainfrom
Conversation
caio-pizzol
changed the title
- Fix correctness bug: ranged selection now groups paragraphs by numId so separate lists stay separate instead of merging into one - Extract shared isOrderedListParagraph() and applyFormatToGroup() helpers - Remove duplicate setNumberedListIcon in defaultItems.js, use canonical superToolbar.updateNumberedListIcon() - Simplify numbering-icon-map.js to direct lookup with nullish coalescing - Simplify toggleList.js branching for format config
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ba46dcdb4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/super-editor/src/core/commands/changeListNumberingType.js
Outdated
Show resolved
Hide resolved
…ListNumberingType - Read existing start value from list definition instead of hardcoding '1' - Apply format to each distinct ilvl in a group so multi-level range selections reformat all levels correctly - Extract SVG icon factory to reduce ~100 lines of duplicated boilerplate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.