fix(track-changes): allow linked style changes in suggesting mode (SD-2182)#2373
Open
caio-pizzol wants to merge 3 commits intomainfrom
Open
fix(track-changes): allow linked style changes in suggesting mode (SD-2182)#2373caio-pizzol wants to merge 3 commits intomainfrom
caio-pizzol wants to merge 3 commits intomainfrom
Conversation
…-2182) Heading/paragraph style changes were silently blocked in suggesting mode. tr.setNodeMarkup() produces a ReplaceAroundStep which was being dropped by the track changes handler. This detects node markup changes (same structure, different attrs) and allows them through. Also removes the empty selection guard from toggleLinkedStyle so keyboard shortcuts work. Note: style changes are applied directly without tracked change marks. Tracked change decoration for paragraph styles is a follow-up.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8adaf131a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/super-editor/src/extensions/track-changes/trackChangesHelpers/replaceAroundStep.js
Outdated
Show resolved
Hide resolved
…kedStyle cursor handling - Add step.insert === 1 check to exclude lift() false positives - Add map.appendMap() for consistency with other step handlers - Fix nodeAt() null-return by always falling back to findParentNodeClosestToPos - Update stale test to reflect new cursor selection behavior
… mode (SD-2182) - Unit: toggleLinkedStyle toggle-off with cursor selection - Unit: isNodeMarkupChange passthrough, lift blocking, map.appendMap - Behavior: heading style apply/toggle in suggesting mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heading/paragraph style changes were silently blocked in suggesting mode.
tr.setNodeMarkup()produces aReplaceAroundStepwhich was being dropped by the track changes handler. This detects node markup changes (same structure, different attrs) and allows them through. Also removes the empty selection guard fromtoggleLinkedStyleso keyboard shortcuts work.Note: style changes are applied directly without tracked change marks. Tracked change decoration for paragraph styles is a follow-up.