Fix: Don't iterate over every attributeto find w:sectPr#2384
Open
johanneswilm wants to merge 1 commit intosuperdoc-dev:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@harbournick I noticed you wrote this code a while back. I am not entirely sure why it was written like that - it creates this problem and so I scaled the walking mechanism back. That should save time as well. It may though be that you are trying to catch more than what I do with this. So please have a look and fix it in another way if needed. What it was doing was comparing with all values of all text fields and all other attributes, which surely isn't what we wanted.
Second reviewer @caio-pizzol