Conversation
|
Status: PASS The three elements/attributes touched by this PR are all correctly handled per the spec:
The logical change — matching continuation cells by grid-column position using |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6b461d4e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (node._vMergeConsumed && Number.isFinite(node._vMergeConsumedGridSpan)) { | ||
| currentColumnIndex = startColumn + node._vMergeConsumedGridSpan; |
There was a problem hiding this comment.
Avoid double-advancing columns for consumed merge cells
When this branch runs, skipOccupiedColumns() has already consumed the same merged columns via activeRowSpans, so incrementing currentColumnIndex by _vMergeConsumedGridSpan advances a second time. In rows that contain a vertical-merge continuation plus later cells (for example [continue, normal]), the next real cell is encoded one column too far, which miscomputes columnWidth and can misalign subsequent merge/colspan handling.
Useful? React with 👍 / 👎.
Table cells didn't get merged vertically
