Attempt to support tags in ToLogstash #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some code to support tags in ToLogstash, but it seemed incomplete, in that there was no moving tags from @fields after moving everything to @fields. Move them back out of fields, so the adding tags and default tags work as intended. Add tests for passing bot a string in tags, and an array ref. We handle the moving outside of the %MAP, because the loop stringifies, and making it not stringify complicated it more than the extra if clause (in my opinion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some code to support tags in ToLogstash, but it seemed incomplete, in
that there was no moving tags from
@fieldsafter moving everything to@fields.Move them back out of fields, so the adding tags and default tags work as
intended. Add tests for passing bot a string in tags, and an array ref.
We handle the moving outside of the %MAP, because the loop stringifies, and
making it not stringify complicated it more than the extra if clause (in my
opinion).