fix: guard base_expression and origin against data:/about: protocols in iframes - #16516
Draft
okxint wants to merge 1 commit into
Draft
fix: guard base_expression and origin against data:/about: protocols in iframes#16516okxint wants to merge 1 commit into
okxint wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/e17b78b3d09c4c7cc85ed01751dec82de8ee7fb0Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: e17b78b The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SvelteKit apps embedded in
<iframe srcdoc>or<iframe src="data:...">crash on hydration with aTypeError: Invalid URLbecausenew URL(base, location)throws whenlocation.protocolisdata:orabout:.There is a secondary issue:
location.originreturns the literal string"null"fordata:URLs, which breaks any origin comparison.A maintainer explicitly invited a fix in the issue thread.
Changes:
packages/kit/src/runtime/server/page/render.jsnew URL(…, location)expressions with a protocol guard. Falls back to''(same as the server-side default) when running underdata:orabout:.packages/kit/src/runtime/client/utils.jsoriginconstant against non-http(s) protocols so it stays''instead of the string"null".Normal
http:/https:behaviour is completely unchanged.Fixes #13226