Conversation
Previously, the client requested the new account's character list first and then cleaned up the old login scene. If the server responded quickly, the new characters could be created and then immediately cleared by the late cleanup, leaving the character selection screen empty. Reproduce against a local OpenMU server: log into one account, return to server selection, then log into a different account and the character selection screen appears empty.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a race condition occurring during the login flow. By reordering the cleanup of the login scene to happen prior to requesting the character list, the application ensures that incoming server responses are not prematurely discarded, thereby fixing an issue where the character selection screen would appear empty. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reorders the scene teardown process in LoginScene.cpp to prevent a race condition where a fast server reply could be cleared prematurely. However, the removal of ClearCharacters() may lead to stale character data being displayed when switching accounts; it is recommended to re-introduce the clear call to ensure a clean state.
|
|
||
| // Tear down the login scene data before asking the server for the | ||
| // account characters, otherwise a fast reply can be cleared again. | ||
| ReleaseLogoSceneData(); |
There was a problem hiding this comment.
While moving ReleaseLogoSceneData() to fix the race condition is correct, completely removing ClearCharacters() might introduce a new bug. If a player logs out from an account and logs into a different one with fewer characters, the characters from the previous account might still be displayed if they are not cleared.
It seems ClearCharacters() is necessary to ensure a clean state for the new account's character list. I'd recommend re-introducing it here, before the SendRequestCharacterList call.
| ReleaseLogoSceneData(); | |
| ReleaseLogoSceneData(); | |
| ClearCharacters(); |
There was a problem hiding this comment.
ReleaseLogoSceneData already calls ClearCharacters so no need to call it twice
1 participant
Previously, the client requested the new account's character list first and then cleaned up the old login scene. If the server responded quickly, the new characters could be created and then immediately cleared by the late cleanup, leaving the character selection screen empty.
Reproduce against a local OpenMU server: log into one account, return to server selection, then log into a different account and the character selection screen appears empty.