change/update cuetag.sh syntax #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) changed quoting on variables according to recommendations from 'shellcheck' utility
2) simplified checks for file type by adding lowercase() function
3) changed expr math to use "$(())"
4) changed check for existence of mid3v2/id3v2 to use the 'type' command instead of 'which'
type is a shell-builtin, which makes it preferable to using the not-entirely-portable 'which' command
5) corrected ID3 tag url typo
6) minor formatting (changing tabbing in 'case' commands for consistency
7) changed double-quotes ("") to single quotes where variables were not referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type is a shell-builtin, so it is preferable to using the external 'which' command
Also removed the METAFLAC, VORBISCOMMENT, and TXTFILE variables by placing their contents in the VORBISTAG variable directly along with the comments explaining each of the options used
Thank you for the hard work. :)