Skip to content

Fix buffer overflow in src/lib/time.c time_frame_to_mmssff #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Cycloctane wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix buffer overflow in src/lib/time.c time_frame_to_mmssff #44

Cycloctane wants to merge 1 commit into from

Conversation

@Cycloctane
Copy link

@Cycloctane Cycloctane commented Sep 28, 2025

time_frame_to_mmssff function in src/lib/time.c has buffer overflow issue. This pr adds range checks to make mm:ss:ff fit in 8 chars. Also replaces sprintf with snprintf.

Reproduce: cueconvert crashes when parsing below file:

FILE "COCC-18150.wav" WAVE
  TRACK 01 AUDIO
    INDEX 01 11111111:00:00

@Cycloctane
fix buffer overflow in time_frame_to_mmssff
6139100 
make mm:ss:ff fit exactly in 8 chars
replace sprintf with snprintf
@Cycloctane
Copy link
Author

Cycloctane commented Nov 16, 2025

@svend Have a look ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Cycloctane