Skip to content

Improve overlay failure hints#59

Merged
SilverSupplier merged 3 commits into
sw1029:mainfrom
SilverSupplier:codex/overlay-feedback-hints
May 25, 2026
Merged

Improve overlay failure hints#59
SilverSupplier merged 3 commits into
sw1029:mainfrom
SilverSupplier:codex/overlay-feedback-hints

Conversation

@SilverSupplier
Copy link
Copy Markdown
Collaborator

@SilverSupplier SilverSupplier commented May 17, 2026

Summary

  • Improve overlay failure reasons for anchor position, scale mismatch, dependency failure, and detached seal proximity.
  • Add structured overlay scale hints so the next-action copy stays aligned with operator-specific scale failures.
  • Make martial_axis dependency feedback player-facing by referring to the prior cut decoration instead of internal operator names.
  • Add EditMode and PlayMode coverage for overlay failure and success feedback paths.

Related Issues

Merge Order

  • Ready to merge directly into main: GitHub reports MERGEABLE / CLEAN after the latest branch refresh.
  • No prerequisite PR remains open for this branch. The earlier timing/build/floor-reaction prerequisites have already landed in main.
  • Suggested remaining queue: merge this PR first, then Strengthen feedback escalation coverage #61, then Strengthen final floor guidance and ending #63. Local merge-tree simulation confirmed that queue has no content conflicts as of 2026-05-26.

Verification

  • Latest GitHub build, test, validate-docs, and codeql checks passed after refreshing the branch.
  • Local merge-tree simulation against the remaining open PRs passed without content conflicts.
  • Previous Unity EditMode and PlayMode coverage was added for the overlay hint paths.
  • npm test; Not run locally, Unity-only change.
  • npm run build; Not run locally, Unity-only change.

Notes

  • Scope: overlay recognition-result copy, overlay scale/anchor/dependency hints, detached seal proximity feedback, and regression coverage.
  • Risk notes: this touches overlay recognition flow and PlayMode coverage, but the branch is now up to date with main and no longer depends on another open PR.

Review Checklist

  • This PR changes user-facing UI or behavior.
  • This PR changes recognizer behavior.
  • This PR changes docs, task state, or project process.
  • This PR changes ML artifacts, datasets, generated outputs, or capture/export behavior.
  • This PR changes logging, survey fields, privacy, or research data handling.
  • This PR needs screenshots or a short playtest note.

Screenshots / Playtest Notes

Batchmode PlayMode coverage confirms detached overlays, oversized overlays, and martial_axis dependency failures show player-facing next-action hints.

@SilverSupplier SilverSupplier requested a review from sw1029 as a code owner May 17, 2026 14:42
…k-hints

# Conflicts:
#	unity/MagicExamHall/Assets/Tests/PlayMode/MagicExamHallSceneSmokeTests.cs
@SilverSupplier SilverSupplier merged commit 420765f into sw1029:main May 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Child #14] overlay anchor/dependency 실패 힌트 개선

1 participant