Fix error annotations #213
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
force-pushed
the
eng/PR-fix-annotations
branch
10 times, most recently
from
8425c7c to
f04a9c2
Compare
The previous method of excluding matrix entries results in complaints annotating the action run (even though the matrix produces the correct entries and _works_), but this noise gets in the way of real errors and may be bothersome. Use a new technique (which amusingly is even simpler) to skip the whole matrix when the enabled flag is off for a group of builds.
jakepetroules
force-pushed
the
eng/PR-fix-annotations
branch
from
f04a9c2 to
358486f
Compare
jakepetroules
commented
Dec 13, 2025
| android-sdk-build: | ||
| name: Swift SDK for Android Build (${{ matrix.swift_version }} - ${{ matrix.os_version }} - NDK ${{ matrix.ndk_version }}) | ||
| runs-on: ubuntu-latest |
Contributor
Author
There was a problem hiding this comment.
This looks useless but interestingly making runs-on dependent on a matrix entry rather than a string literal prevents it from creating a job with an empty configuration when the matrix is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method of excluding matrix entries results in complaints annotating the action run (even though the matrix produces the correct entries and works), but this noise gets in the way of real errors and may be bothersome.
Use a new technique (which amusingly is even simpler) to skip the whole matrix when the enabled flag is off for a group of builds.