[LLDB] Support importing modules from llvmcas:// URLs #12025
+568
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
adrian-prantl
requested review from
augusto2112,
cachemeifyoucan,
felipepiovezan and
kastiglione
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
It seems there is an assertion in test case of unhandled error. I can't seem to spot it but you might want to fix it.
adrian-prantl
force-pushed
the
166576110
branch
2 times, most recently
from
eeee46d to
b4ee158
Compare
adrian-prantl
changed the title
Author
Found it :-) |
augusto2112
reviewed
Dec 18, 2025
lldb/source/Plugins/TypeSystem/Swift/LLDBExplicitModuleLoader.h
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/LLDBExplicitModuleLoader.cpp
Outdated
Show resolved
Hide resolved
adrian-prantl
force-pushed
the
166576110
branch
5 times, most recently
from
b06a198 to
3231ef3
Compare
Author
|
@swift-ci test |
adrian-prantl
force-pushed
the
166576110
branch
from
3231ef3 to
c5867f1
Compare
Author
|
@swift-ci test |
fredriss
approved these changes
Dec 19, 2025
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
Mostly good to me. Just one comments about how to unique CASConfiguration.
adrian-prantl
force-pushed
the
166576110
branch
2 times, most recently
from
5ee8c59 to
83c99d0
Compare
Author
|
@swift-ci test |
This patch creates a wrapper LLDB Swft module loader that owns both an ESML (explicit Swift module loader) and a CAS explicit module loader, dispatches module discovery calls to both, and tries to find each module in the CAS first, before trying the ESML. rdar://166576110
adrian-prantl
force-pushed
the
166576110
branch
from
83c99d0 to
572034f
Compare
Author
|
@swift-ci test |
cachemeifyoucan
approved these changes
Dec 19, 2025
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
Mostly LGTM.
Nit: For LLVM change, will be good to add unit test there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch creates a wrapper LLDB Swft module loader that owns both an ESML (explicit Swift module loader) and a CAS explicit module loader, dispatches module discovery calls to both, and tries to find each module in the CAS first, before trying the ESML.
rdar://166576110