Minor fixes to borrow accessors #86023
Merged
+155
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have support for borrowing switch on Copyable types. It is supported for ~Copyable types, but the return expression emission for borrow accessors is not yet implemented. Diagnose instead of crashing the compiler.
meg-gupta
requested review from
CodaFi,
DougGregor,
eeckstein,
hamishknight,
hborla,
jckarter,
kavon,
rintaro,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci test |
eeckstein
reviewed
Dec 14, 2025
| return %2 | ||
| } | ||
|
|
||
| sil [ossa] @call_mutate_accessor : $@convention(thin) (@inout Wrapper, @owned Klass) -> () { |
Contributor
There was a problem hiding this comment.
The CHECK lines are missing here.
(Note that the main test file for EscapeUtils is SILOptimizer/escape_info.sil. But testing the change here is also fine).
meg-gupta
force-pushed
the
miscborrowfixes
branch
from
10dd321 to
0c5fe56
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test macOS platform |
Contributor
Author
|
@swift-ci smoke test windows platform |
Contributor
Author
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes crashes in SILGenCleanup and EscapeUtils for borrow accessors.
Also a adds a diagnostic for borrow/mutate accessors in enums.