[Platform] Improvements on Uuid handling & MessageNormalizer
#1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
changed the title
MessageNormalizer
Guikingone
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Bug
OskarStark
changed the title
MessageNormalizerMessageNormalizer
OskarStark
reviewed
Nov 27, 2025
Guikingone
force-pushed
the
refactor/message_identifier
branch
4 times, most recently
from
f4e9f4b to
5896900
Compare
Guikingone
force-pushed
the
refactor/message_identifier
branch
7 times, most recently
from
e8cc913 to
604d5aa
Compare
chr-hertel
requested changes
Dec 7, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
My assumption as user would be that a withId clones the instance - and that would also help here, right?
we could keep the instantiation of id in the constructor but overwrite if needed with that withId
Contributor
Author
|
Make sense, I was focused on the method and not its usages, to be honest, I was looking at the method last night and said to myself: Damn, that's ugly as hell in the constructor 😅 |
Guikingone
force-pushed
the
refactor/message_identifier
branch
from
604d5aa to
6fa847e
Compare
Guikingone
force-pushed
the
refactor/message_identifier
branch
from
6fa847e to
27f59fd
Compare
Guikingone
force-pushed
the
refactor/message_identifier
branch
from
27f59fd to
ae9096d
Compare
Member
well, we've all been there - over and over ... |
Guikingone
force-pushed
the
refactor/message_identifier
branch
3 times, most recently
from
bbe4588 to
d373508
Compare
chr-hertel
force-pushed
the
refactor/message_identifier
branch
from
d373508 to
a1751b7
Compare
chr-hertel
approved these changes
Dec 12, 2025
Member
|
Thank you @Guikingone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MessageNormalizer::denormalize(), it looks like we're recreating a newUuid::v7()in the constructorIdentifierAwareTraitthat expose two methodsgetId()andwithId, the last one allows to either specify an exiting Uuid or use av7one