[Platform] Respect SSE comments in streaming mode #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lochmueller
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Bug
Contributor
Author
|
Hmm... looks like the problem is not so easy to handle. The Symfony\Component\HttpClient\Chunk\ServerSentEvent should handle comments in the right way, and no comments should be part of the iteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have same problems with OpenRouter streaming mode, because openrouter send a
: OPENROUTER PROCESSINGto keep the SSE connectionopen(details on https://openrouter.ai/docs/api/reference/streaming#additional-information ). The current integration of the RawHttpResult do not handle that. As described in the OpenRouter documentation, the handling of SSE comments based on the Spec https://html.spec.whatwg.org/multipage/server-sent-events.html#event-stream-interpretation is not handled in the right way. We have to drop lines starting with a:because these are comments and cannot be handled via json_decode.Fixed the integration and add a test incl. a comment.