Skip to content

Conversation

@llupa
Copy link
Contributor

@llupa llupa commented Dec 10, 2025

Q A
Bug fix? no
New feature? yes
Docs? yes
Issues
License MIT

@llupa llupa force-pushed the elastic-store branch 2 times, most recently from 21c2889 to a9700d5 Compare December 10, 2025 21:24
@llupa llupa marked this pull request as ready for review December 10, 2025 21:24
@carsonbot carsonbot changed the title Add ElasticSearch Store support Add ElasticSearch Store support Dec 10, 2025
@OskarStark OskarStark changed the title Add ElasticSearch Store support [Store][ElasticSearch] Add bridge Dec 11, 2025
@OskarStark
Copy link
Contributor

Thanks for the bridge, please add the missing files like License, composer.json etc., add an example in the examples folder and update the docker compose file, thanks

@OskarStark OskarStark changed the title [Store][ElasticSearch] Add bridge [Store][Elasticsearch] Add bridge Dec 11, 2025
@llupa
Copy link
Contributor Author

llupa commented Dec 11, 2025

Thanks for the bridge, please add the missing files like License, composer.json etc., add an example in the examples folder and update the docker compose file, thanks

I saw the other bridges and added the files accordingly. Let me know if this is enough.

Edit: I see the failing CI, and I will update the PR later

@OskarStark
Copy link
Contributor

OskarStark commented Dec 11, 2025

CleanShot 2025-12-11 at 14 59 54@2x

-> Elasticsearch, lowercase s

@OskarStark
Copy link
Contributor

Please add an entry to examples/commands/store.php and update (after rebase) splitsh.json file in the root

@OskarStark
Copy link
Contributor

To fix

------ ------------------------------------------------------------------------------------------------------------ 
  Line   rag/elasticsearch.php                                                                                       
 ------ ------------------------------------------------------------------------------------------------------------ 
  31     Instantiated class Symfony\AI\Store\Bridge\Elasticsearch\Store not found.                                   
         🪪  class.notFound                                                                                          
         💡  Learn more at https://phpstan.org/user-guide/discovering-symbols                                        
  48     Call to method setup() on an unknown class Symfony\AI\Store\Bridge\Elasticsearch\Store.                     
         🪪  class.notFound                                                                                          
         💡  Learn more at https://phpstan.org/user-guide/discovering-symbols                                        
  53     Parameter #3 $store of class Symfony\AI\Store\Indexer constructor expects Symfony\AI\Store\StoreInterface,  
         Symfony\AI\Store\Bridge\Elasticsearch\Store given.                                                          
         🪪  argument.type                                                                                           
  56     Parameter #2 $store of class Symfony\AI\Agent\Bridge\SimilaritySearch\SimilaritySearch constructor expects  
         Symfony\AI\Store\StoreInterface, Symfony\AI\Store\Bridge\Elasticsearch\Store given.                         
         🪪  argument.type                                                                                           
 ------ ------------------------------------------------------------------------------------------------------------ 

you need to require your new bridge package in /examples/composer.json

@OskarStark
Copy link
Contributor

Please upgrade phpunit:

@llupa llupa force-pushed the elastic-store branch 3 times, most recently from b891cef to 55cf241 Compare December 12, 2025 14:08
@carsonbot carsonbot changed the title [Store][Elasticsearch] Add bridge [Elasticsearch] Add bridge Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants